Please check my segFault

Question

I got the seg fault in here. I confused. Please help me out. f1 and y are both pointer for struct node. I want to turn y's left to f1 right.

#include <stdio.h>
#include <stdlib.h>
struct node{
            int data;
              struct node* left;
              struct node* right; 
};
int main(){
    struct node* f1=(struct node *)malloc(sizeof(struct node));
    struct node* y=(struct node *)malloc(sizeof(struct node));
    f1->data=10;
    y=f1->right;
    f1->right=y->left;   //seg fault is in this line. 

    return 0;
}`

Read also [about casting of malloc result in C](http://stackoverflow.com/questions/605845/do-i-cast-the-result-of-malloc) — Ilya, Sep 26 '14 at 22:56
`f1->right` is not initialize. and `y` has been overwritten.(memory leak). — BLUEPIXY, Sep 26 '14 at 22:56

score 2 · Answer 1 · answered Sep 26 '14 at 22:55

2

y=f1->right sets y to uninitialised memory. y->left is now invalid. Try running this with Valgrind.

answered Sep 26 '14 at 22:55

apmasell

7,033
19
28

Please check my segFault

1 Answers1