Unable to recover a full image using java bufferwriter?

Question

From Input Stream i am reading the image data and convert it to string. From string am writing to an image directly by following type.

final BufferedReader reader = new BufferedReader(new InputStreamReader(in));
final char[] cbuf = new char[1024];
final int length = reader.read(cbuf);

String packet=new String(cbuf,0,length);
BufferedWriter out = null ;
FileWriter fstream ;
File file = new File(fileName);
fstream = new FileWriter(file);
out.write(packet);

Please guide me in this issue. I am not getting full image. enter image description here

an image is binary data, and therefore some of it will not be able to be converted to a string. try using a byte array — Scary Wombat, Oct 01 '14 at 05:04
you are also only reading the first 1024 chars. You should loop around until `read` == -1 — Scary Wombat, Oct 01 '14 at 05:08
@ScaryWombat OP still gets something as output, so probably initialization was omitted. — Basilevs, Oct 01 '14 at 05:13

score 0 · Answer 1 · edited May 23 '17 at 12:13

0

final BufferedReader reader = new BufferedReader(new InputStreamReader(in));

Decodes input using default encoding potentially corrupting data.

out.write(packet);

Encodes characters using default encoding potentially corrupting data.

Read documentation on API you use. Only perform conversion with default or unknown encoding when you absolutely need it.

Read/convert an InputStream to a String

edited May 23 '17 at 12:13

Community

1
1

answered Oct 01 '14 at 05:06

Basilevs

22,440
15
57
102

wrong method. He is using String(char[] value, int offset, int count) – Scary Wombat Oct 01 '14 at 05:14
@Basilevs i read upto end of the image and write it together. But still am getting like above image. verified check sum also. No idea .. – Rameshbabu Oct 01 '14 at 05:45
how big is your image? bigger than 1024 bytes? – Scary Wombat Oct 01 '14 at 05:47
If checksum is the same for original file, this is no longer java question. – Basilevs Oct 01 '14 at 05:48
approximately 10KB to 20KB. Also am reading upto an end of the packet. Lenght of an image and checksum also matched finally. But final image was like this only.. @ScaryWombat – Rameshbabu Oct 01 '14 at 05:49
I guess that I am mis-reading your code then. It does not show any looping to the end of a fileinputstream. – Scary Wombat Oct 01 '14 at 05:53

Unable to recover a full image using java bufferwriter?

1 Answers1