Shell script works in the console but not when saved as a text file

Question

Consider this simple shell script:

#!/bin/sh
fruitlist="Apple Pear Tomato Peach Grape"
for fruit in $fruitlist
do
   if [ "$fruit" = "Tomato" ] || [ "$fruit" = "Peach" ]
   then
      echo "I like ${fruit}es"
   else 
      echo "I like ${fruit}s"
   fi
done

When I paste it to a cygwin window it works fine however when I save it as a text file test.sh and run it from the cygwin terminal I'm getting this:

$ ./test.sh
./test.sh: line 4: syntax error near unexpected token `$'do\r''
'/test.sh: line 4: `do

However, if I remove newlines it works:

#!/bin/sh
fruitlist="Apple Pear Tomato Peach Grape"
for fruit in $fruitlist
do if [ "$fruit" = "Tomato" ] || [ "$fruit" = "Peach" ]
   then echo "I like ${fruit}es"
   else echo "I like ${fruit}s"
fi done

How can I make the script more readable by maintaining new lines in the file, \n doesn't seem to work.

You have added some weird characters in the DOS -> UNIX conversion. Try to use `dos2unix` to the file to "clean" it. — fedorqui, Oct 06 '14 at 12:32
Might have indeed, I have ademded the question with more useful information, see if you can help now? — Joly, Oct 06 '14 at 12:35
possible duplicate of [\r character in shell script](http://stackoverflow.com/questions/5230798/r-character-in-shell-script) — Charles Duffy, Oct 06 '14 at 19:49

score 5 · Accepted Answer · edited May 23 '17 at 12:28

Your \r characters come from a Windows file, where the new lines are defined with \r\n. In UNIX the new line is defined just with \n, hence the \r stays "orphan" and causes these problems.

What you can do is to convert the file to UNIX mode with the command dos2unix.

More info in: Does Windows carriage return \r\n consist of two characters or one character?:

Two characters combined represent a new line on Windows. Whereas on Linux, \n represents new line. It moves cursor to the start of new line on Linux. On Windows, the cursor will stay at the same column in the console but on the next line.

\r is carriage return;

\n is line feed.

score 1 · Answer 2 · answered Oct 06 '14 at 19:37

Not answering the question.

A case statement would fit well here. As well as an actual array.

fruitlist=( Apple Pear Tomato Peach Grape )
for fruit in "${fruitlist[@]}"; do
    case $fruit in
        Tomato|Peach) echo "I like ${fruit}es" ;;
        *) echo "I like ${fruit}s" ;;
    esac
done

score 1 · Answer 3 · answered Oct 13 '14 at 09:50

I always add the following header to my shell scripts to let cygwin ignore CR:

#!/bin/sh
if [ "$OSTYPE" = "cygwin" ]; then shopt -s igncr 2>/dev/null; fi # New version of Cygwin complains itself of CR

Note that the comment at the end of the second line is mandatory.

score 0 · Answer 4 · answered Jul 31 '19 at 10:28

0

To fix cygwin's running of scripts that have windows end-of-line characters, without editing scripts or installing dos2unix:

Add these lines to ~/.bash_profile, and then re-start cygwin:

export SHELLOPTS
set -o igncr

Credit.

answered Jul 31 '19 at 10:28

Clare Macrae

3,670
2
31
45

Shell script works in the console but not when saved as a text file

4 Answers4