Java for Selenium - String comparison

Question

I am facing an issue in if statement for below code. I am not able to log into if statement even with correct condition. Is my syntax correct?

String NicotineProduct="Not in the last 5 years"

if (NicotineProduct=="No, Never"||NicotineProduct=="Not in the last 5 years"||NicotineProduct=="Not in the last 3 years")
 {    
    if (rateclass=="Pref Best No Nicotine")
             rateclassval=1;
    else if (rateclass=="Pref No Nicotine")
           rateclassval=2;
    else if (rateclass=="Select No Nicotine")
           rateclassval=3;
    else if (rateclass=="Standard No Nicotine")
           rateclassval=4;
 }

No, your syntax is not correct in that it does not bare the semantics you want. Always use [String.equals()](http://docs.oracle.com/javase/6/docs/api/java/lang/String.html#equals%28java.lang.Object%29) for String comparisons; everything else means asking for trouble. — JimmyB, Oct 10 '14 at 13:59

score 0 · Answer 1 · edited May 23 '17 at 12:06

Always use .equals for String comparisons:

if (NicotineProduct.equals("No, Never")||NicotineProduct.equals("Not in the last 5 years")||NicotineProduct.equals("Not in the last 3 years")) {
    if (rateclass.equals("Pref Best No Nicotine"))
         rateclassval=1;
    else if (rateclass.equals("Pref No Nicotine"))
         rateclassval=2;
    else if (rateclass.equals("Select No Nicotine"))
         rateclassval=3;
    else if (rateclass.equals("Standard No Nicotine"))
         rateclassval=4;
}

See this other question/answer:

How do I compare strings in Java?

score 0 · Answer 2 · answered Oct 10 '14 at 14:01

0

String.equals() is the preferred way for comparing string values.

answered Oct 10 '14 at 14:01

VMi

346
3
16

Java for Selenium - String comparison

2 Answers2