Reading and printing values in a file

Question

I am trying to read a file and then print it but the loop doesn't ends. Why??

My file contains one line such as

    66,67,256,258,69,73,

This is my input :

char d;
char code2 [12]={0};
string file1;
cout<<"Input file name"<<endl;
cin>>file1;
string file2;
cout<<"Input file name"<<endl;
cin>>file2;

ifstream input;
input.open(file1.c_str());
ofstream output;
output.open(file2.c_str());

while(! input.eof())
    {
        int i=0;
        while(d != ',' && i < sizeof(code2))
        {
            input>>d;
            code2[i]=d;
            i++;
        }
        file2<<code2;
    }

While debugging, I am getting a garbage value of code2. Thus, the loop doesn't ends at end of while.

Don't use `eof`. There are countless questions and answers on SO about this very topic. Search. — Captain Obvlious, Oct 11 '14 at 16:35
Read _[Why is iostream::eof inside a loop condition considered wrong?](http://stackoverflow.com/q/5605125/1870232)_ — P0W, Oct 11 '14 at 16:38
Consider what happens when `d == ','` starting from the top of the nested loop (hint: how is `input` supposed to reach eof?). — David G, Oct 11 '14 at 16:39

score 2 · Accepted Answer · answered Oct 11 '14 at 16:54

Your use of eof() is wrong, and you are using d before initializing it. Try something more like this instead:

char d;
char code2 [13]={0};
string file1;
cout<<"Input file name"<<endl;
cin>>file1;
string file2;
cout<<"Input file name"<<endl;
cin>>file2;

ifstream input;
input.open(file1.c_str());
ofstream output;
output.open(file2.c_str());

int i = 0;
while(input >> d)
    {
    if ((d == ',') || (i == 12))
        {
        code2[i] = 0;
        file2<<code2;
        i = 0;
        }
    code2[i] = d;
    i++;
    }

if (i > 0)
    {
    code2[i] = 0;
    file2<<code2;
    }

Reading and printing values in a file

1 Answers1