jQuery onClick Event not firing

Question

I have a click event for an a pagination list

Its not firing.

$(".pagination-page").click(function()
{
    //event.preventDefault();

    var page = $(this).val();

    $('#search-results-display').load('includes/search.php?query=<? echo $_SESSION['search_term']; ?>&page=' + page);
});

PHP While loop generating the pagination (only the generation of the pagination not the rest of it. The SQL query is working, that has been tested

while ($tmpPageCnt > 0) 
{
    $retvar .= '<li class="active"><a href="#" class="pagination-page">'.$tmpPage.'</a></li>';
}

return $retvar;

Please could you shed some light as to why it's not

There's nothing inherently wrong with the event handler you posted. Maybe there's no `".pagination-page"` element when this code executes? You can confirm this by debugging the JavaScript code in the browser. — David, Oct 13 '14 at 15:13
They don't appear until after the user has submitted a search query - So would I need to load it in with the search results? — Zach Ross-Clyne, Oct 13 '14 at 15:23
Related: [Direct vs. Delegated - jQuery .on()](http://stackoverflow.com/questions/8110934/direct-vs-delegated-jquery-on) — Jonathan Lonowski, Oct 13 '14 at 15:34

Amit Joki · Accepted Answer · 2014-10-13T15:23:54.220

1

Since you're dynamically creating it, I suppose you need to use event-delegation

$(document).on('click', ".pagination-page", function() {
    var page = $(this).text();
    $('#search-results-display').load('includes/search.php?query=<? echo $_SESSION['search_term']; ?>&page=' + page);
});

And since it is <a> you should be using .text() as anchors don't have values.

edited Oct 13 '14 at 15:23

answered Oct 13 '14 at 15:15

Amit Joki

58,320
7
77
95

Could you give an example below this issue showing what's needed to be done – Zach Ross-Clyne Oct 13 '14 at 15:16
Quotes for PHP and JavaScript strings won't necessarily clash with each other. They're parsed separately at different times. – Jonathan Lonowski Oct 13 '14 at 15:17
That's what I thought which is why I didn't escape any of it – Zach Ross-Clyne Oct 13 '14 at 15:17
@ZachRoss-Clyne I don't know about php, but give it a try and note that `.text()` – Amit Joki Oct 13 '14 at 15:18
As I've said on the other answers, the event itself is not getting called, so whether its `.text()` or not the actual `.click` function is not getting called – Zach Ross-Clyne Oct 13 '14 at 15:21
@ZachRoss-Clyne check out now – Amit Joki Oct 13 '14 at 15:24
What is the difference between what it was and what it is now? – Zach Ross-Clyne Oct 13 '14 at 15:25

score -1 · Answer 2 · edited Oct 13 '14 at 17:45

-1

Changing .val(); to .html(); should solve the problem

edited Oct 13 '14 at 17:45

chopper

6,649
7
36
53

answered Oct 13 '14 at 15:16

msimmons

146
1
3
15

2

The actual event itself is not getting fired, so this, at this stage, is not an issue (will keep in mind though) – Zach Ross-Clyne Oct 13 '14 at 15:17
1

This does not provide an answer to the question. To critique or request clarification from an author, leave a comment below their post - you can always comment on your own posts, and once you have sufficient [reputation](http://stackoverflow.com/help/whats-reputation) you will be able to [comment on any post](http://stackoverflow.com/help/privileges/comment). – IdeaHat Oct 13 '14 at 15:37
@ZachRoss-Clyne - my apologies, as I was making a mock-up on my end, it appeared to not be fireing either. However it was just a case of nothing being returned by the .val(). I [wrongly] assumed that what corrected things in my mock-up was the entirety of your issue. – msimmons Oct 13 '14 at 21:20
@MadScienceDreams - I thought it was the answer to the question (see my reply to Zach), however it seems I was mistaken. – msimmons Oct 13 '14 at 21:21

jQuery onClick Event not firing

2 Answers2