php oops including another page

Question

Here is my code in database.php

    $db_host = "localhost";
    $db_username = "root";
    $db_pass = "";
    $db_name = "ss";
    $con = new PDO('mysql:host=localhost;dbname=app', $db_username, $db_pass);

In my class page

include_once "database.php";
class article_fun
{
  public function myfun()
    {
     $sqlcreate = $con->query("selct query")
     }
}

How do we do we use $con->query("select query") getting an error Undefined variable: con how to fix this?

score 1 · Answer 1 · answered Oct 14 '14 at 13:10

1

Pass$con as a parameter to article_fun::myFun()

class article_fun
{
  public function myfun($con)
  {
     $sqlcreate = $con->query("selct query")
  }
}

FYI, in PHP it is convention to start class names with a capital letter and use camelCase:

class ArticleFun

answered Oct 14 '14 at 13:10

John Conde

217,595
99
455
496

cant we pass it to constructor?? and use the same in all other functions of same class?? – Your Friend Oct 14 '14 at 13:14

Octfx · Answer 2 · 2014-10-14T13:35:21.907

Your created variables are outside of the function scope.
So you can't access variables outside a function from inside the function.
Try to use the magic function __construct()
Like this:

class article_fun{
  private $_con;

  public function __construct( $con ){
    $this -> _con = $con;
  };

  public function myfun(){
    $sqlcreate = $this -> _con->query("selct query")
  }
}

Now you just have to pass the $convar to the Class like so:

$article_fun = new article_fun( $con );

Harutyun Abgaryan · Accepted Answer · 2014-10-14T13:38:49.507

1

use this

class article_fun
{
private $con;
public function __construct($con){
$this->con=$con;
}
  public function myfun()
    {
     $sqlcreate = $this->con->query("selct query")
     }
}

call this

include_once "database.php";

new article_fun($con);

or use this

class article_fun
    {
    private $con;
    public function __construct(){
    $db_host = "localhost";
    $db_username = "root";
    $db_pass = "";
    $db_name = "ss";
    $this->con = new PDO('mysql:host=localhost;dbname=app', $db_username, $db_pass);
    }
      public function myfun()
        {
         $sqlcreate = $this->con->query("selct query")
         }
    }

edited Oct 14 '14 at 13:38

answered Oct 14 '14 at 13:14

Harutyun Abgaryan

2,013
1
12
15

iam getting an error `Warning: Missing argument 1 for article_fun::__construct(), called in` – Your Friend Oct 14 '14 at 13:29
iam using ur first method – Your Friend Oct 14 '14 at 13:35
as a parameters to class? – Your Friend Oct 14 '14 at 13:38
call this include_once "database.php"; new article_fun($con); – Harutyun Abgaryan Oct 14 '14 at 13:38

score 0 · Answer 4 · answered Oct 14 '14 at 13:07

0

class article_fun
{
  public function myfun()
  {
     global $con;
     $sqlcreate = $con->query("select query")
  }
}

Your variable is definied in the global context and you try to use it in a method of a class.

answered Oct 14 '14 at 13:07

andreashager

667
3
9

Don't use `global`. That's a bad practice. – John Conde Oct 14 '14 at 13:10
It was the better solution. If we can demonstrate the proper way to do something we should. Otherwise newbies learn bad habits that are hard to break. – John Conde Oct 14 '14 at 13:11
@andreashager but what if i want to use in other function of the same class?? again i have to define global in other function also? – Your Friend Oct 14 '14 at 13:12
@user3436481 see fox's answer for the conventional solution to this question – cypherabe Oct 14 '14 at 13:17

score -1 · Answer 5 · edited May 23 '17 at 11:49

-1

Use global variable

  $GLOBALS['con'] = $yourConnection;

Check this link for answer How to declare a global variable in php?

edited May 23 '17 at 11:49

Community

1
1

answered Oct 14 '14 at 13:17

Hassan Shifaz

45
2
7

This is a *very* bad practice – John Conde Oct 14 '14 at 13:32

php oops including another page

5 Answers5