Searching for alternative to endless loop in Java

Question

I am doing my homework which is about a chat program. It has two interfaces, one is for server and the second one is for client. Program flow is as the following:

Server starts a connection on a certain port
Client starts and tries to connect to server
If everything is OK, they start chatting
One of the terminals type "TERMINATE" conversation will be over.

This program has been originated from Deitel&Deitel's Java How To Program 6e book. The example has only two elements for each interfaces: a displayArea (JTextArea) for displaying messages and an input (JTextField) for entering messages.

Pressing Enter will send the message to the otherside.

A piece of code of Server.java is below. It does some repetitive actions in an endless loop.

public void runServer() {
    // set up server to receive connections; process connections
    SwingUtilities.invokeLater(new Runnable() {

        public void run() 
        {
            try {

                // Step 1: Create a ServerSocket.
                String portNum = txtPort.getText();
                server = new ServerSocket(Integer.parseInt(portNum), 100);

                InetAddress ip = InetAddress.getLocalHost();
                txtServerIP.setText(ip.getHostAddress());

                while (true) {

                    try {
                        waitForConnection(); // Step 2: Wait for a connection.
                        getStreams(); // Step 3: Get input & output streams.
                        processConnection(); // Step 4: Process connection.
                    }
                    // process EOFException when client closes connection
                    catch (EOFException eofException) {
                        System.err.println("Client terminated the connection.");
                    }
                    finally {
                        closeConnection(); // Step 5: Close connection.
                        ++counter;
                    }
                } // end while
            } // end try
            // process problems with I/O
            catch (IOException ioException) {
                ioException.printStackTrace();
            }
        }
    });
} // end method runServer

It works well on original code. I have decided to add some GUI elements to the interfaces and added an Application window using Eclipse Luna 4.4.1. I have added an input for IP address and port number. Then I have added a button 'Open Connection' for Server GUI, and another button 'Connect to the Server' for Client GUI.

Now I run Server.java and it works until I click on 'Open Connection' button. Then button stays pressed eventhough I release and form does not response. After that I run Client.java and it connects to the server and gets 'Connection successful' message from server. I close Client window after sending a few messages then suddenly all the messages appear on the server window.

Now I understand that non-responsing of the Server window is because of while ( true ) loop. In other words the program is working well but cannot update interface fast enough. I want to change it with a port listener maybe, or something else which is faster or more responsive.

How can I change it?

I have changed

public void runServer() {
    // set up server to receive connections; process connections
    SwingUtilities.invokeLater(new Runnable() {...

to

public void runServer() {
    // set up server to receive connections; process connections
    SwingUtilities.invokeLater(new Thread() {...

but situation stays still.

You may access my codes

ServerGUI.java @ http://pastebin.com/pVRi6EfC

ClientGUI.java @ http://pastebin.com/HfftM159

Original codes:

Server.java @ http://pastebin.com/6Q5Z00gb

Client.java @ http://pastebin.com/uCGFGknf

Ah, `SwingUtilities.invokeLater` will run the code on the same `Thread`. See [here](http://stackoverflow.com/a/6568120/2479481). I'll update my answer. — Luke Willis, Oct 21 '14 at 18:27

score 2 · Answer 1 · edited May 23 '17 at 10:33

2

The issue is that you are using SwingUtilities.invokeLater. As this answer explains, invokeLater executes the run body inside the application's primary Thread. Since your UI is also operating in this Thread, you'll need to use another method.

You'll want to put that infinite loop in a Thread and call start explicitly so it won't block your UI.

class MyChatServer extends Thread {
    public void run() {
        // the while loop
    }
}

Then, you can start up the Thread when your "Open Connection" button is pressed with:

MyChatServer server = new MyChatServer();
server.start();

Without explicitly creating a new Thread, your application will only have one Thread to work with. This Thread will be shared between the UI and any other work that you need to perform. So, when you have a bit of work (like your while(true)) that hogs your only Thread, your UI will freeze until it is given control again.

So, by creating a new Thread, you are allowing the UI to maintain control and not freeze.

edited May 23 '17 at 10:33

Community

1
1

answered Oct 21 '14 at 18:16

Luke Willis

8,429
4
46
79

@zkanoca Is that `run` method a member of a class that implements `Thread`? or maybe `Runnable`? and are you calling `Thread.start` to run the server? – Luke Willis Oct 21 '14 at 18:24
Yes, it is Runnable as you said. – zkanoca Oct 21 '14 at 18:27
I do not know much about threading stuff. Can you help me more? I mean on my code? – zkanoca Oct 21 '14 at 21:20
@zkanoca I'd start by separating your logic out into a View and a Controller (see: [MVC](http://www.tutorialspoint.com/design_pattern/mvc_pattern.htm)). Your View should extend `JFrame`, and your Controller should extend `Thread`. When your button is clicked, you should `start` the Controller. Then, when your Controller receives data from the client, the Controller should update the View. – Luke Willis Oct 21 '14 at 21:40

score 1 · Answer 2 · edited May 23 '17 at 10:26

1

Your infinite cycle is a busy wait, which prevents your UI from refreshing. You have two problems:

busy wait is not the best approach
waiting prevents UI actualization and event-handling

Instead of busy waiting, please, look for alternatives.

Also, you should use UI in a different thread from your engine. You might want to read about swing concurrency as well.

edited May 23 '17 at 10:26

Community

1
1

answered Oct 21 '14 at 18:52

Lajos Arpad

64,414
37
100
175

Searching for alternative to endless loop in Java

2 Answers2