File saving outputstream on android

Question

I am making an android apps that can take photos. I have written some codes to save the photos taken by the app. The directory that I want to save the file is in the internal storage and in the folder named DCIM. However, the app crashes everytime I tried to save the photo. Below is my code:

FileOutputStream outStream = null;
                     try {
                         outStream = new FileOutputStream(String.format(
                                 "sdcard/DCIM/jgjk.jpg", System.currentTimeMillis()));
                         outStream.write(data);
                         outStream.close();
                         Log.d("Log", "onPictureTaken - wrote bytes: " + data.length);
                     } catch (FileNotFoundException e) {
                         e.printStackTrace();
                     } catch (IOException e) {
                         e.printStackTrace();
                     } finally {
                     }

Is there anything wrong with the code?

What do you intend String.format("sdcard/DCIM/jgjk.jpg", System.currentTimeMillis()) to do? This seems wrong. — Michael Krause, Oct 22 '14 at 03:43
Michael: Yes it seems wrong. I am looking for suggestions here. — Mary June, Oct 22 '14 at 03:44
As panini mentioned, please attach your logcat with the exception — Michael Krause, Oct 22 '14 at 03:46
look at this answer http://stackoverflow.com/a/7887114/964741 — RajaReddy PolamReddy, Oct 22 '14 at 03:47
That is external storage not internal. So you may be missing the permission. And you should be discovering the path by API, not hard-coding/guessing it. Finally, files are usually not in the DCIM folder but rather a subfolder there of. — Chris Stratton, Oct 22 '14 at 03:52

score 0 · Accepted Answer · answered Oct 22 '14 at 03:51

This will work fine

Getting Bitmap in onActivityResult

public void onActivityResult(int requestCode, int resultCode, Intent data) 
    {
         if(requestCode==PIC_CROP)
        {
             if(resultCode==RESULT_OK)
             {
             Bundle extras = data.getExtras();
                if (extras != null) {               
                    Bitmap bmp = extras.getParcelable("data");
                    savePhoto(bmp);
                }
             }
        }

}


public void savePhoto(Bitmap bmp)
        {
        dir = Environment.getExternalStorageDirectory().toString() + "/DCIM/"; 
        File newdir = new File(dir); 
        newdir.mkdirs();
        FileOutputStream out = null;

        //file name
        Calendar c = Calendar.getInstance();
        String date = fromInt(c.get(Calendar.MONTH))
                    + fromInt(c.get(Calendar.DAY_OF_MONTH))
                    + fromInt(c.get(Calendar.YEAR))
                    + fromInt(c.get(Calendar.HOUR_OF_DAY))
                    + fromInt(c.get(Calendar.MINUTE))
                    + fromInt(c.get(Calendar.SECOND));
        File imageFileName = new File(newdir, "crop_"+date.toString() + ".jpg");

        try
        {
         out = new FileOutputStream(imageFileName);
         bmp.compress(Bitmap.CompressFormat.JPEG, 100, out);
         out.flush();
         out.close();
         out = null;
        } catch (Exception e)
        {
        e.printStackTrace();
        }
        }


public String fromInt(int val)
{
return String.valueOf(val);
}

yea welcome..if you found that useful up vote so that other may be benefited . — Rajan Kali, Oct 22 '14 at 09:50
My current reputation does not allow me to up vote any post or comment. — Mary June, Oct 22 '14 at 10:17
rajan : to what type shall I initialize the object dir with? — Mary June, Oct 22 '14 at 10:57
and to eclipse show that cannot invoke getExtras for the array type byte. — Mary June, Oct 22 '14 at 11:13
Hey sorry MaryJune,for delay in response...dir is actually an String.....and getExtras is for Intent,which is third parameter in `public void onActivityResult(int requestCode, int resultCode, Intent data)` function — Rajan Kali, Oct 25 '14 at 14:45

File saving outputstream on android

1 Answers1