45

I have the following values:

int a=1; 
int b=0;
int c=2;
int d=2;
int e=1;

How do i concatenate these values so that i end up with a String that is 10221; please note that multiplying a by 10000, b by 1000.....and e by 1 will not working since b=0 and therefore i will lose it when i add the values up.

skolima
  • 31,963
  • 27
  • 115
  • 151
Shamli
  • 467
  • 1
  • 4
  • 3

22 Answers22

53

The easiest (but somewhat dirty) way:

String result = "" + a + b + c + d + e

Edit: I don't recommend this and agree with Jon's comment. Adding those extra empty strings is probably the best compromise between shortness and clarity.

Michael Borgwardt
  • 342,105
  • 78
  • 482
  • 720
  • 1
    Dirty? What? http://stackoverflow.com/questions/2506474/is-concatenating-with-an-empty-string-to-do-a-string-conversion-really-that-bad – polygenelubricants Apr 20 '10 at 11:48
  • @polygenelubricants: well, I happen to disagree with the majority opinion on that point. – Michael Borgwardt Apr 20 '10 at 11:50
  • 18
    I'm not a fan of this - I think `a + "" + b + "" + c + "" + d + "" + e ` would be clearer, myself - although more longwinded, of course. It's just too easy to look at "a + b" and think that will be adding the integers together, IMO. – Jon Skeet Apr 20 '10 at 11:53
  • 1
    @polygenelubricants: Thanks for pointing out that question - I hadn't spotted it before... – Jon Skeet Apr 20 '10 at 11:54
  • 3
    I think I would use a StringBuffer with chained appends. – extraneon Apr 20 '10 at 12:02
  • Isn't direct string concatenation a little inefficient compared to StringBuffer/Builder methods ? – Andrei Ciobanu Apr 20 '10 at 12:10
  • 4
    @Andrei: What is the root of all evil again? Besides, one-line string concatenation will be compiled into a StringBuilder. It's only in more complex scenarios (usually involving loops) where concatenation should be avoided. – Michael Borgwardt Apr 20 '10 at 12:20
  • 1
    What about `"" + (a) + (b) + (c) + (d) + (e)`? Just as concise, and it draws just enough attention to itself that you go "Ah, I see what's going on here...". – polygenelubricants Apr 20 '10 at 14:21
36

This worked for me.

int i = 14;
int j = 26;
int k = Integer.valueOf(String.valueOf(i) + String.valueOf(j));
System.out.println(k);

It turned out as 1426

Zeeshan
  • 741
  • 1
  • 7
  • 21
36

Michael Borgwardt's solution is the best for 5 digits, but if you have variable number of digits, you can use something like this:

public static String concatenateDigits(int... digits) {
   StringBuilder sb = new StringBuilder(digits.length);
   for (int digit : digits) {
     sb.append(digit);
   }
   return sb.toString();
}
polygenelubricants
  • 376,812
  • 128
  • 561
  • 623
  • Thanks everyone for your answers, I'm always working with 5 digits, but in many cases they start with 0, so Michael's way's the wat way ;-) – Shamli Apr 20 '10 at 12:06
  • This also works with 0s. For 5 digits, it always give the same result as Michael's; its only advantage (which you don't need) is that it works with variable number of digits. – polygenelubricants Apr 20 '10 at 12:09
  • Varargs + foreach combo is best. – polygenelubricants Apr 20 '10 at 12:19
  • 2
    this is cleaner and has better performance too... string concatenation is messy and results in a lot of unnecessary string generation. modern VMs may mitigate that... not sure, but i think this is much cleaner nonetheless. – PaulP1975 Apr 20 '10 at 12:37
16

just to not forget the format method

String s = String.format("%s%s%s%s%s", a, b, c, d, e);

(%1.1s%1.1s%1.1s%1.1s%1.1s if you only want the first digit of each number...)

user85421
  • 28,957
  • 10
  • 64
  • 87
13

Actually,

int result = a * 10000 + b * 1000 + c * 100 + d * 10 + e;
String s = Integer.toString(result);

will work.

Note: this will only work when a is greater than 0 and all of b, c, d and e are in [0, 9]. For example, if b is 15, Michael's method will get you the result you probably want.

T .
  • 4,874
  • 3
  • 23
  • 36
7

How about not using strings at all...

This should work for any number of digits...

int[] nums = {1, 0, 2, 2, 1};

int retval = 0;

for (int digit : nums)
{
    retval *= 10;
    retval += digit;
}

System.out.println("Return value is: " + retval);
5

If you multiply b by 1000, you will not lose any of the values. See below for the math.

10000
    0
  200
   20
    1
=====
10221
xpda
  • 15,585
  • 8
  • 51
  • 82
Daniel A. White
  • 187,200
  • 47
  • 362
  • 445
5
StringBuffer sb = new StringBuffer();
sb.append(a).append(b).append(c)...

Keeping the values as an int is preferred thou, as the other answers show you.

Björn
  • 29,019
  • 9
  • 65
  • 81
4

Others have pointed out that multiplying b by 1000 shouldn't cause a problem - but if a were zero, you'd end up losing it. (You'd get a 4 digit string instead of 5.)

Here's an alternative (general purpose) approach - which assumes that all the values are in the range 0-9. (You should quite possibly put in some code to throw an exception if that turns out not to be true, but I've left it out here for simplicity.)

public static String concatenateDigits(int... digits)
{
    char[] chars = new char[digits.length];
    for (int i = 0; i < digits.length; i++)
    {
        chars[i] = (char)(digits[i] + '0');
    }
    return new String(chars);
}

In this case you'd call it with:

String result = concatenateDigits(a, b, c, d, e);
Jon Skeet
  • 1,421,763
  • 867
  • 9,128
  • 9,194
4

For fun... how NOT to do it ;-)

String s = Arrays.asList(a,b,c,d,e).toString().replaceAll("[\\[\\], ]", "");

Not that anyone would really think of doing it this way in this case - but this illustrates why it's important to give access to certain object members, otherwise API users end up parsing the string representation of your object, and then you're stuck not being able to modify it, or risk breaking their code if you do.

JRL
  • 76,767
  • 18
  • 98
  • 146
3

Using Java 8 and higher, you can use the StringJoiner, a very clean and more flexible way (especially if you have a list as input instead of known set of variables a-e):

int a = 1;
int b = 0;
int c = 2;
int d = 2;
int e = 1;
List<Integer> values = Arrays.asList(a, b, c, d, e);
String result = values.stream().map(i -> i.toString()).collect(Collectors.joining());
System.out.println(result);

If you need a separator use:

String result = values.stream().map(i -> i.toString()).collect(Collectors.joining(","));

To get the following result:

1,0,2,2,1

Edit: as LuCio commented, the following code is shorter:

Stream.of(a, b, c, d, e).map(Object::toString).collect(Collectors.joining());
flavio.donze
  • 7,432
  • 9
  • 58
  • 91
  • 1
    Or : `Stream.of(a, b, c, d, e).map(Object::toString).collect(Collectors.joining());` Or: `IntStream.of(a, b, c, d, e).mapToObj(Integer::toString).collect(Collectors.joining());` – LuCio Oct 26 '18 at 21:42
2
int number =0;
int[] tab = {your numbers}.

for(int i=0; i<tab.length; i++){
    number*=10;
    number+=tab[i];
}

And you have your concatenated number.

Hafiz Waleed Hussain
  • 1,062
  • 12
  • 25
kryzystof
  • 190
  • 2
  • 13
1

Assuming you start with variables:

int i=12;
int j=12;

This will give output 1212:

System.out.print(i+""+j); 

And this will give output 24:

System.out.print(i+j);
Justin Ethier
  • 131,333
  • 52
  • 229
  • 284
ajay
  • 27
  • 1
1

I would suggest converting them to Strings.

StringBuilder concatenated = new StringBuilder();
concatenated.append(a);
concatenated.append(b);
/// etc...
concatenated.append(e);

Then converting back to an Integer:

Integer.valueOf(concatenated.toString());
Grundlefleck
  • 124,925
  • 25
  • 94
  • 111
  • He seems to want a String as the end result, so the parsing is unnecessary (and if that were actually wanted, the correct solution would be to just add up the numbers without any String tomfoolery) – Michael Borgwardt Apr 20 '10 at 11:48
  • Good point on him wanting a String, but if the numbers were just added, the result would be 6, not 10221... – Grundlefleck Apr 20 '10 at 11:52
  • @polygenelubricants: Totally agree with you - forget this answer, Michael or Jon's answer are the best solutions going on the information given :) – Grundlefleck Apr 20 '10 at 11:53
  • @polygenelubricants: ... or yours ;-) – Grundlefleck Apr 20 '10 at 12:12
1

Use StringBuilder

StringBuilder sb = new StringBuilder(String.valueOf(a));
sb.append(String.valueOf(b));
sb.append(String.valueOf(c));
sb.append(String.valueOf(d));
sb.append(String.valueOf(e));
System.out.print(sb.toString());
Shervin Asgari
  • 23,901
  • 30
  • 103
  • 143
1

People were fretting over what happens when a == 0. Easy fix for that...have a digit before it. :)

int sum = 100000 + a*10000 + b*1000 + c*100 + d*10 + e;
System.out.println(String.valueOf(sum).substring(1));

Biggest drawback: it creates two strings. If that's a big deal, String.format could help.

int sum = a*10000 + b*1000 + c*100 + d*10 + e;
System.out.println(String.format("%05d", sum));
cHao
  • 84,970
  • 20
  • 145
  • 172
1

You can Use

String x = a+"" +b +""+ c+""+d+""+ e;
int result = Integer.parseInt(x);
Ali
  • 617
  • 10
  • 25
0

Best solutions are already discussed. For the heck of it, you could do this as well: Given that you are always dealing with 5 digits,

(new java.util.Formatter().format("%d%d%d%d%d", a,b,c,d,e)).toString()

I am not claiming this is the best way; just adding an alternate way to look at similar situations. :)

ring bearer
  • 20,383
  • 7
  • 59
  • 72
0

NOTE: when you try to use + operator on (string + int) it converts int into strings and concatnates them ! so you need to convert only one int to string

public class scratch {

public static void main(String[] args){

    int a=1;
    int b=0;
    int c=2;
    int d=2;
    int e=1;
    System.out.println( String.valueOf(a)+b+c+d+e) ;
}
0
//Here is the simplest way 
public class ConcatInteger{
    public static void main(String[] args) {
      
      int [] list1={1,2,3};
      int [] list2={1,9,6};
      
      String stNum1="";
      String stNum2="";
   
      for(int i=0 ; i<3 ;i++){
        stNum1=stNum1+Integer.toString(list2[i]);   //Concat done with string  
      }
      
      for(int i=0 ; i<3 ;i++){
        stNum2=stNum2+Integer.toString(list1[i]);
      }
      
      int sum= Integer.parseInt(stNum1)+Integer.parseInt(stNum2); // Converting string to int
      
         System.out.println(sum);  
    } 
}
-1

Couldn't you just make the numbers strings, concatenate them, and convert the strings to an integer value?

Zach
  • 19
  • 3
-4
public class joining {

    public static void main(String[] args) {
        int a=1; 
        int b=0;
        int c=2;
        int d=2;
        int e=1;

        String j = Long.toString(a);
        String k = Long.toString(b);
        String l = Long.toString(c);
        String m = Long.toString(d);
        String n = Long.toString(e);

       /* String s1=Long.toString(a);    // converting long to String
        String s2=Long.toString(b);
        String s3=s2+s1;
        long c=Long.valueOf(s3).longValue();    // converting String to long
        */

        System.out.println(j+k+l+m+n);  
    }
}
Balasubramanian
  • 700
  • 7
  • 26