showing current time in TimePicker in android

Question

i use this code to show current time in TimePicker, but i don't know really,why it doesn't show correctly!? for example now time (system time) is 2:56 PM, but it shows 2:56 AM!. how can i solve it? thanks.

 private long timer1 = 0; 
 ...

switch (view.getId()) {
        case R.id.add1: {
            if (timer1 == 0) {
                timer1 = getCurrentTime();
            }
            Calendar calendar = Calendar.getInstance();
            calendar.setTimeInMillis(timer1);

            TimePicker timePicker = (TimePicker) findViewById(R.id.tp_1);
            timePicker.setCurrentHour(calendar.get(Calendar.HOUR));
            timePicker.setCurrentMinute(calendar.get(Calendar.MINUTE));



            break;
         . ..              
        }

private long getCurrentTime() {
    Calendar calendar = GregorianCalendar.getInstance();
    return calendar.getTimeInMillis();
}

and also i have the same problem when i want to convert this time into String form with this method below:

private String convertTimeToString(long time) {
    Calendar calendar = Calendar.getInstance();
    calendar.setTimeInMillis(time);

    int hour = calendar.get(Calendar.HOUR_OF_DAY);
    //int hour = get;
    int minute = calendar.get(Calendar.MINUTE);

    String timeSet;
    if (hour > 12) {
        hour -= 12;
        timeSet = "PM";
    } else if (hour == 0) {
        hour += 12;
        timeSet = "AM";
    } else if (hour == 12) {
        timeSet = "PM";
    } else {
        timeSet = "AM";
    }

    String minutes;
    if (minute < 10) {
        minutes = "0" + minute;
    } else {
        minutes = String.valueOf(minute);
    }
    // Append in a StringBuilder
    return String.format("%s:%s %s", hour, minutes, timeSet);

}

please help me!

check my answer you must use hour = c.get(Calendar.HOUR_OF_DAY); — DevOps85, Nov 10 '14 at 09:45

sberezin · Accepted Answer · 2014-11-11T15:04:57.567

4

Updated
1) wrong hour problem: Try to edit code like this:

...
timePicker.setCurrentHour(calendar.get(Calendar.HOUR_OF_DAY));
...

2) string representation problem: general approach to convert date/time to string is following:

String format = "hh:mm"; // or any other format - see note below
SimpleDateFormat formatter = new SimpleDateFormat(format);
formatter.format(yourDate);

or when you use long timestamp last line will be:

formatter.format(new Date(yourLongTimestamp));

Useful links:
Different date/time format symbols you may look here.
Test different format patterns you may here.

edited Nov 11 '14 at 15:04

answered Nov 10 '14 at 09:49

sberezin

3,266
23
28

thanks , but there is another problem, when i want to convert time into String form. i explain it now time – Mina Dahesh Nov 11 '14 at 14:12
Not at all. when you get a useful answer it's good to accept it (check-mark at the upper left corner) – sberezin Nov 12 '14 at 09:24
excuse me, i checked mark but i don't know it changes, i don't understand your mean,but i don't as soon as i write thanks commend. – Mina Dahesh Nov 12 '14 at 09:35
now time, i mark all the answers post, but they are unmarked! (after i scroll the page) – Mina Dahesh Nov 12 '14 at 09:39

score 2 · Answer 2 · answered Nov 10 '14 at 09:45

2

// display current time
    public void setCurrentTimeOnView() {

        tvDisplayTime = (TextView) findViewById(R.id.tvTime);
        timePicker1 = (TimePicker) findViewById(R.id.timePicker1);

        final Calendar c = Calendar.getInstance();
        hour = c.get(Calendar.HOUR_OF_DAY);
        minute = c.get(Calendar.MINUTE);

        // set current time into textview
        tvDisplayTime.setText(
                    new StringBuilder().append(pad(hour))
                                       .append(":").append(pad(minute)));

        // set current time into timepicker
        timePicker1.setCurrentHour(hour);
        timePicker1.setCurrentMinute(minute);

    }

answered Nov 10 '14 at 09:45

DevOps85

6,473
6
23
42

thanks, but the output of this method must be String, because i need it in other parts of this proje. please help me how can i do it now? – Mina Dahesh Nov 11 '14 at 14:07
try to see last answer in this post: http://stackoverflow.com/questions/3992820/android-how-to-get-the-time-from-a-timepicker-when-it-is-typed-in – DevOps85 Nov 11 '14 at 19:42
with this: return String.format("%s:%s %s", Integer.toString(hour), minutes, timeSet); – DevOps85 Nov 11 '14 at 19:48

score 2 · Answer 3 · answered Nov 10 '14 at 09:45

2

Replace this line:

timePicker.setCurrentHour(calendar.get(Calendar.HOUR));

To:

hourStart = c.get(Calendar.HOUR_OF_DAY);

answered Nov 10 '14 at 09:45

Pratik Dasa

7,439
4
30
44

thanks , but there is another problem, when i want to convert time into String form. i explain it now time . – Mina Dahesh Nov 11 '14 at 14:12
@user3671748 please accept and upvote the answer. So others can take benefit of this. – Pratik Dasa Nov 12 '14 at 08:39

showing current time in TimePicker in android

3 Answers3