C++ Characters [Sentences/Words]

Question

I'm a beginner with C++ and I wish to learn more about characters but I've got a problem. I have tried to make a program which copies a sentence and adds a new line ('\n') between spaces (' '), like separating a sentence word by word.

int main()
{
    char s[256], tmp[256];
    int m, n = 0, i;
    cout << "String: ";
    gets(s);
    for (i = 0; i <= strlen(s) - 1; i++)
    {
        if (s[i] == ' ')
        {
            m = i;
            if (n > strlen(s)) tmp[0] = 0;
            else
            {
                if (m >= strlen(s) - n + 1)
                    for (i = 0; i <= strlen(s) - n + 1; i++)
                        tmp[i] = s[n - 1 + i];
                else
                    for (i = 0; i < m; i++) tmp[i] = s[n - 1 + i];
            }
            strcat(tmp, "\n");
            n = i;
        }
    }
    cout << tmp;
    system("PAUSE");
}

[Never use `gets`.](http://stackoverflow.com/questions/4309746/safe-alternative-to-gets) — indiv, Nov 14 '14 at 20:36
firstly m,n are the limits of a substring;i used a loop through all characters and when find a space, mean last character of a word, after this I tried to copy character by character that word, and pass on another — Robert, Nov 14 '14 at 20:37
It is straightforward when using C++ rather than C. http://stackoverflow.com/questions/2896600/how-to-replace-all-occurrences-of-a-character-in-string — RTLinuxSW, Nov 14 '14 at 21:01
That's a lot of complicated code. [Here's how you can do that in one line](http://ideone.com/0gPYwS). — Felix Glas, Nov 14 '14 at 22:15

score 2 · Accepted Answer · answered Nov 14 '14 at 20:37

2

Try

Replacing

for(i=0;i<=strlen(s)-1;i++)
{
    if(s[i] == ' ')
    {
        m=i;
        if(n>strlen(s)) tmp[0] = 0;
        else 
        {
            if(m>=strlen(s)-n+1) 
                for(i=0;i<=strlen(s)-n+1;i++) tmp[i] = s[n-1+i];
            else 
                for(i=0;i<m;i++) tmp[i]=s[n-1+i];
        }
        strcat(tmp,"\n");
        n=i;
    }
}

with

for(i=0;i<=strlen(s)-1;i++)
{
    if(s[i] == ' ')
    {
        tmp[i] = '\n';
    }
    else
    {
        tmp[i] = s[i];
    }
}

answered Nov 14 '14 at 20:37

marsh

2,592
5
29
53

no no no... I want to copy the string s in tmp, WORD by WORD – Robert Nov 14 '14 at 20:43
I am confused, could you try explaining better what exactly you want your tmp variable to contain? I thought you wanted the original string with new lines instead of spaces. – marsh Nov 14 '14 at 20:49
Well... I'm trying to separate each word like the strtok function do but in another way...and put them into a new string – Robert Nov 14 '14 at 20:54

C++ Characters [Sentences/Words]

1 Answers1