Can\'t set headers after they are sent

Question

I am trying to replicate the Sails application from this video.
Here is my UserController:

module.exports = {
    'new': function(req, res) {
        res.view()
    },
    'create': function(req, res, next) {
        User.create(req.params.all(), function userCreated(err, user) {
            if(err) {
                console.log(err);
                req.session.flash = {
                    err: err
                }
                return res.redirect('/user/new');
            }
            //res.redirect('/user/show/'+user.id);
            res.json(user);
        });
    },
    'show': function(req, res, next) {
        User.findOne(req.param('id'), function foundUser(err, user) {
            if(err) return next(err);
            if(!user) return next();
            res.view({
                user: user
            });
        });
    }
};

When I am trying to access the show function http://localhost/user/show/4 I am getting below error:

http.js:691                                                                                                                                           
    throw new Error('Can\'t set headers after they are sent.');                                                                                       
          ^                                                                                                                                           
Error: Can't set headers after they are sent.                                                                                                         
    at ServerResponse.OutgoingMessage.setHeader (http.js:691:11)                                                                                      
    at ServerResponse.res.setHeader (/home/codio/.nvm/v0.10.25/lib/node_modules/sails/node_modules/express/node_modules/connect/lib/patch.js:63:22)   
    at next (/home/codio/.nvm/v0.10.25/lib/node_modules/sails/node_modules/express/node_modules/connect/lib/proto.js:158:13)                          
    at resume (/home/codio/.nvm/v0.10.25/lib/node_modules/sails/node_modules/express/node_modules/connect/lib/middleware/static.js:65:7)              
    at SendStream.error (/home/codio/.nvm/v0.10.25/lib/node_modules/sails/node_modules/express/node_modules/connect/lib/middleware/static.js:80:37)   
    at SendStream.EventEmitter.emit (events.js:95:17)                                                                                                 
    at SendStream.error (/home/codio/.nvm/v0.10.25/lib/node_modules/sails/node_modules/express/node_modules/send/lib/send.js:147:51)                  
    at SendStream.onStatError (/home/codio/.nvm/v0.10.25/lib/node_modules/sails/node_modules/express/node_modules/send/lib/send.js:248:48)            
    at /home/codio/.nvm/v0.10.25/lib/node_modules/sails/node_modules/express/node_modules/send/lib/send.js:320:26                                     
    at Object.oncomplete (fs.js:107:15)

I am not able to fund out any solution for that. Can anyone please help me to resolve this issue?

Note: I am using Sails.Js version : v0.10.5

possible duplicate of [Node.js Error: Can't set headers after they are sent](http://stackoverflow.com/questions/7042340/node-js-error-cant-set-headers-after-they-are-sent) — Brendan, Nov 16 '14 at 21:51
The above question is not solution of my question. I am able to find where I am sending the header twice. — chanchal1987, Nov 17 '14 at 10:00
Apologies. After looking over your code I can't seem to find it either. — Brendan, Nov 18 '14 at 01:54

score 0 · Answer 1 · answered Nov 17 '14 at 19:19

I'm not seeing where the duplicate header is being sent, but what I'd do if I were you is to try rewriting your show handler to look like this:

'show': function(req, res, next) {
  User.findOne(req.param('id'), function foundUser(err, user) {
    if(err) {
      return next(err);
    } else if (!user) {
      return next();
    } else {
      res.view({
        user: user
      });
    }
  });
}

By forcing the if / else if / else flow, you GUARANTEE that only one of those statements will be ran. I'd give that a try and see if it fixes your issue, then continue debugging from there.

I have also tried the code you have shared. But still getting the same error. Please check the source at [here](https://bitbucket.org/chanchal1987/test-sails/src/99204cd28b1c64f32dc1c4321f9dae4925d28809/activityOverload/?at=master) for more details. — chanchal1987, Nov 18 '14 at 06:21

Can\'t set headers after they are sent

1 Answers1

Linked