Curious as to why my constructors don't seem to be working

Question

The following is how I was taught to use constructors, and it seems to work for one variable, but when I use a few it seems to act odd.

I'm not too sure what to do to fix this, but I would like some direction. Thanks in advance!

#include <iostream>
#include <string>

using namespace std;

class Numbers
{
public:
    Numbers (int a, int b, int c)
    {
        setNum (a);
        setNum (b);
        setNum (c);
    }

    void setNum (int x, int y, int z)
    {
        numbers = x;
        digits = y;
        numerals = z;
    }

    int getNum ()
    {
        return numbers;
        return digits;
        return numerals;
    }

    int add (int x, int y, int z)
    {
        int answer = x + y + z;
        return answer;
    }

private:
    int numbers;
    int digits;
    int numerals;
};

int main ()
{
    Numbers numbersobject (12,13,14);
    cout << numbersobject.getNum () << endl;

    return 0;
}

How many arguments does `setNum` take? How many do you pass when you call it? And what do you think will happen at the first`return` statement in `getNum`? — Some programmer dude, Nov 21 '14 at 20:24

score 2 · Accepted Answer · answered Nov 21 '14 at 20:25

Odd meaning compile error?!

In the constructor, look at your setNum, it must take 3 parameters. You probably need

setNum(a,b,c);

And you CANNOT return 3 elements in getNum, using 3 return statements. If you need to return more than 2 elements, use std::tuple, or std::pair for 2 elements.

score 0 · Answer 2 · edited May 23 '17 at 12:05

0

You could change your constructor to use a member initialization list

Numbers (int a, int b, int c)
: numbers {a}, digits {b}, numerals {c} {}

Or the older version

Numbers (int a, int b, int c)
{
    numbers = a;
    digits = b;
    numerals = c;
}

edited May 23 '17 at 12:05

Community

1
1

answered Nov 21 '14 at 20:29

Cory Kramer

114,268
16
167
218

score 0 · Answer 3 · answered Nov 21 '14 at 20:30

I suggest you simplify your constructor

class Numbers
{
  public:  
    Numbers(int a, int b, int c)
    : numbers(a), digits(b), numerals(c) // Initialization list
    { ; }
    //...
};

In your simple class, there is no need for the constructor to call a setter function.

Curious as to why my constructors don't seem to be working

3 Answers3