Correct way to cast using unique_ptr

Question

I'm trying to compile the following code but I get this error:

error: no viable conversion from 'unique_ptr' to 'unique_ptr'

What I'm trying to do is create a smart pointer that wraps some objects and then use them as listeners.

#include <iostream>
#include <vector>
#include <memory>

class Table {

  public:
    struct Listener{ 
      virtual void handle(int i) = 0;
    };

    std::vector<std::unique_ptr<Listener>> listeners_;

    void add_listener(std::unique_ptr<Listener> l){
      listeners_.push_back(l);
    }

};


struct EventListener: public Table::Listener {
  void handle(int e){  
    std::cout << "Something happened! " << e << " \n";
  }
};

int main(int argc, char** argv)
{
  Table table;
  std::unique_ptr<EventListener> el;
  table.add_listener(el);

  return 0;
}

Any ideas will be appreciate!

This won't necessarily fix your issue, but unique pointers should be moved not copied. — BlamKiwi, Nov 28 '14 at 03:05
Possible dupe of http://stackoverflow.com/q/11002641/3093378 — vsoftco, Nov 28 '14 at 03:07

score 2 · Accepted Answer · answered Nov 28 '14 at 03:06

std::unique_ptr cannot be copied, only moved : you can use std::move :

#include <iostream>
#include <vector>
#include <memory>

class Table {

  public:
    struct Listener{ 
      virtual void handle(int i) = 0;
    };

    std::vector<std::unique_ptr<Listener>> listeners_;

    void add_listener(std::unique_ptr<Listener> l){
      listeners_.push_back(std::move(l));
    }

};


struct EventListener: public Table::Listener {
  void handle(int e){  
    std::cout << "Something happened! " << e << " \n";
  }
};

int main(int argc, char** argv)
{
  Table table;
  std::unique_ptr<EventListener> el;
  table.add_listener(std::move(el));

  return 0;
}

Live demo

score 0 · Answer 2 · answered Nov 28 '14 at 03:19

0

There is no copy constructor for unique_ptr

From cppreference.com:

"Copy construction is disabled for objects of type unique_ptr (see move constructors, 6 and 7)."

You have to move it explicitly, or extract raw pointer and copy it around

answered Nov 28 '14 at 03:19

Severin Pappadeux

18,636
3
38
64

Correct way to cast using unique_ptr

2 Answers2