Angular JS controller not working

Question

I am just starting out with AngulasJS, and when I run this code, I am getting the error "Argument 'teacherCtrl' is not a function, got undefined", but it is clearly defined. Please help.

<body>
    <script>
        function teacherCtrl($scope) {
            $scope.teachers = [
                { name: 'Bill Melega', subject: 'History'},
                { name: 'Top Stanfa', subject: 'English'},
                { name: 'Mike Bremer', subject: 'English'}
            ];
        }
    </script>
    Name: <input type="text" ng-model="search"> {{search}}

    <table ng-controller="teacherCtrl">
        <tr ng-repeat="teacher in teachers | filter:search">
            <td ng-repeat="property in teacher">
                {{ property }}
            </td>
        </tr>
    </table>

</body>

Can you please show us your full code? also where is your `ng-init`? — gdoron, Dec 06 '14 at 22:39
Possible duplicate of http://stackoverflow.com/questions/25111831/controller-not-a-function-got-undefined-while-defining-controllers-globally/25111942#25111942 ? — PSL, Dec 07 '14 at 02:07

score 1 · Answer 1 · answered Dec 06 '14 at 22:42

Provided that you have set up ng-app, here's the reason: in Angular 1.3+ you can't define controllers like that anymore. You need the whole thing: app.controller(....

It all comes down to how you create controllers. Luckily the fix is the way you should be writing your controllers (though you can opt into the old behavior). When I’ve taught AngularJS in the past, I’ve created controllers using global functions as that makes the story simple. Usually when I’ve taught it before, I’m trying to help people understand the concepts, not the best practices. Starting with AngularJS 1.3, this isn’t the default behavior.

Read more about it here: http://wildermuth.com/2014/11/11/Angular_1_3_and_Breaking_Change_for_Controllers

Angular JS controller not working

1 Answers1