Stop service in an activity

Question

I'm using following code to stop my service

Intent intent = new Intent(MainActivity.this, UsageRecorderService.class);
stopService(intent);

And this is my service that works indefinitely

public class UsageRecorderService extends IntentService {

  public UsageRecorderService() {
      super("UsageRecorder");
  }

  @Override
  protected void onHandleIntent(Intent intent) {

      while (true) {

          UsageRecorder.recordUsages(this, false);

          SystemClock.sleep(10000);
      }
   }
}

Why does not stop my service?

The answer: http://stackoverflow.com/questions/8709989/how-to-stop-intentservice-in-android — eleven, Dec 13 '14 at 14:35

score 2 · Accepted Answer · answered Dec 13 '14 at 15:27

This code would work

public class UsageRecorderService extends IntentService {

    private boolean mStop = false;

    public UsageRecorderService() {
        super("UsageRecorder");
    }

    public final Object sLock = new Object();

    public void onDestroy() {
        synchronized (sLock) {
            mStop = true;
        }
    }


    @Override
    protected void onHandleIntent(Intent intent) {
        while (true) {
            synchronized (sLock) {
                if (mStop) break;
            }
            UsageRecorder.recordUsages(this, false);
            SystemClock.sleep(10000);
        }
    }

}

You can use stopService

Intent intent = new Intent(MainActivity.this, UsageRecorderService.class);
stopService(intent);

Also I recommend to read Services guide to understand what is going there.

@MousaJafari both are for [Synchronization](https://docs.oracle.com/javase/tutorial/essential/concurrency/sync.html) of read/write `mStop` field at different threads — gio, Dec 13 '14 at 21:19

Jerome · Answer 2 · 2014-12-13T15:31:08.833

0

Activity:

sendBroadcast(new Intent(ACTION_STOP));

IntentService

public class UsageRecorderService extends IntentService {
  private static final String TAG  = "UsageRecorderService";
  String ACTION_STOP = "com.xxx.UsageRecorderService.ACTION_STOP";
  boolean stop;

  public UsageRecorderService() {
    super("UsageRecorder");
  }

  private BroadcastReceiver receiver = new BroadcastReceiver() {
    @Override public void onReceive(Context context, Intent intent) {
      if (ACTION_STOP.equals(intent.getAction())) {
        stop = true;
      }
    }
  };

  @Override public void onCreate() {
    super.onCreate();
    IntentFilter intentFilter = new IntentFilter(ACTION_STOP);
    registerReceiver(receiver, intentFilter);
  }

  @Override
  protected void onHandleIntent(Intent intent) {
    Log.i(TAG,"onHandleIntent");
    while (true && !stop) {
      Log.i(TAG,"----running----");
      //UsageRecorder.recordUsages(this, false);
      SystemClock.sleep(10000);
    }
  }

  @Override public void onDestroy() {
    super.onDestroy();
    unregisterReceiver(receiver);
  }
}

edited Dec 13 '14 at 15:31

answered Dec 13 '14 at 14:40

Jerome

1,749
1
14
40

http://stackoverflow.com/questions/10250745/proper-way-to-stop-intentservice/10250896#10250896 – Jerome Dec 13 '14 at 15:02
I've tested it and does not work, Maybe the problem is my while loop? – Mousa Jafari Dec 13 '14 at 15:02
`stopService(intent);` won't call `onHandleIntent` – gio Dec 13 '14 at 15:03
sorry, it's my mistake.use `startService(intent)` – Jerome Dec 13 '14 at 15:05
`onHandleIntent` won't be called after 1st `startService` – gio Dec 13 '14 at 15:06
Yep, I just realize that your `handleIntent()` is always running because the `while(ture)`, so my answer won't not work. `BroadcastReceiver` is another choice – Jerome Dec 13 '14 at 15:14

score 0 · Answer 3 · answered Jun 08 '17 at 05:58

0

An IntentService is designed to stop itself only when all the requests present in the work queue have been handled.Android stops the service after all start requests have been handled.

answered Jun 08 '17 at 05:58

Shinoo Goyal

601
8
10

Stop service in an activity

3 Answers3

Linked