Undefined is not a function"""

Question

Why do I get Uncaught type error: undefined is not a function"""
I have no J Query in my page

Here is my code:

function CDec(Currency) {
    var number = Currency.replace(/[^0-9\.]+/g,"");
    return number;
}

Calling of the function

SellPrice.value = "$" +  CurrencyFormat(CDec(ListPrice.value * (1 + CDec(Markup.value))) * CDec(Mutiplier.value));

and

Markup.value =   CurrencyFormat(100 * (CDec(SellPrice.value)-CDec(Netcost.value)) / CDec(Netcost.value)) + "%"

Well Currency is supposed to be a string but may contain 10.5% or $100 or skcnbdskcbdks — Pieter de Vries, Dec 22 '14 at 18:02
We need to see what your Currency.replace function looks like, I'm guessing it doesn't return anything — Alex J, Dec 22 '14 at 18:05
Currency is a number in your example so `Currency.toString().replace(...)` (This makes replacing non-numerics a bit redundant ...) — Alex K., Dec 22 '14 at 18:05
The result of a `*` operation is always a number, not a string. — Pointy, Dec 22 '14 at 18:05
Without full snippet, I can only suggest the easiest way is a pre-convertion from number to string, `Currency = Currency.toString();` at the top of `CDec` function — hjl, Dec 22 '14 at 18:07
I fixed the problem by adding tostring indeed it was wrong for me to assume it was a string. I wish we could define the variables in javascript. Maybe you can I don't know but I am new to javascript. — Pieter de Vries, Dec 22 '14 at 18:09
Its worth noting that your CDec() implementation would convert any negative number to a positive one which may have undesirable implications ... — Alex K., Dec 22 '14 at 18:14
@Alex K Please let me know how I can improve my code as you are sugessting — Pieter de Vries, Dec 22 '14 at 18:15
In your example you pass a valid number (the result of a mathematical expression) to CDec() so there is no point in calling CDec() in the first place. For other unknown values, deal with a leading `-` — Alex K., Dec 22 '14 at 18:18
I don't quit understand I am using this to make sure that the user has entered a valid amount and to make sure that the calculation can be done correctly. Let me know if I am missing something or a snippet might help. Thanks for you help. — Pieter de Vries, Dec 22 '14 at 18:22
I guess I should have Explained my self better, I am having textbox values in the CDec function. The texboxes could contain $12.00 or 33.5% and I cant do a calculation on this. — Pieter de Vries, Dec 22 '14 at 18:25

score 2 · Answer 1 · answered Dec 22 '14 at 18:09

2

Simply convert numbers that are passed as parameter to string, e.g.:

function CDec(Currency) {
    var number = (Currency + '').replace(/[^0-9\.]+/g,"");
    return number;
}

But I would recommend you to validate input data first.

answered Dec 22 '14 at 18:09

Kiril

2,935
1
33
41

This seems to look like a hack .tosring looks better in my opinion but your code does work. – Pieter de Vries Dec 22 '14 at 18:11
1

There're lots of ways to convert number to string. And **mostly** adding an empty string is the fastest way. Of course it depends on browser and amount of conversions. See more [here](http://stackoverflow.com/questions/5765398/whats-the-best-way-to-convert-a-number-to-a-string) – Kiril Dec 22 '14 at 18:14

score 2 · Accepted Answer · answered Dec 22 '14 at 18:12

2

function CDec(Currency) {
    Currency = Currency.toString();
    var number = Currency.replace(/[^0-9\.]+/g,"");
    return number;
}

answered Dec 22 '14 at 18:12

hjl

2,794
3
18
26

score 1 · Answer 3 · edited May 23 '17 at 12:05

Given your comments you would be better off replacing known possible characters and validating the return result.

function CDec(Currency) {
    if (typeof Currency !== "number")
        Currency = parseFloat(Currency.toString().replace(/[£$%]/g, ""));

    return Currency;
}

console.log( CDec(1.22) );
console.log( CDec(-1.22) );
console.log( CDec("$1.22") );
console.log( CDec("$1.22%") );
console.log( CDec("-£1.22") );

if (isNaN(CDec("Woof"))
   alert("invalid!");

You should also probably scale your values: Precise Financial Calculation in JavaScript. What Are the Gotchas?

Undefined is not a function"""

3 Answers3