XAML ComboBox SelectionChanged Fires OnLoad

Question

If I have a ComboBox that has a SelectionChanged event, it fires when I'm loading the control.

So at page load I set the SelectedValue and the SelectionChanged event fires which is not what I want to happen.

What is the accepted apporach to stopping this?

score 18 · Accepted Answer · answered May 04 '10 at 00:40

18

Two obvious solutions to this would be 1) Wait until the Loaded event of the Window/Page/UserControl which contains the ComboBox and hook up SelectionChanged there...eg in the constructor:

// set the inital selected index for the combo box here...

this.Loaded += (s, args) =>
               {
                    cmbBox.SelectionChanged += 
                            new SelectionChangedEventHandler(HandleChanged);
               };

or 2) Check that the ComboBox has loaded in the selection changed handler before doing anything and return if it hasn't...eg in the handler:

if (!cmbBox.IsLoaded)
        return;

I would prefer number 1 as it doesn't require the check every time the SelectionChanged handler is fired.

answered May 04 '10 at 00:40

Simon Fox

10,409
7
60
81

@SANDEEP as I mentioned, put it in the constructor (of the view that contains the control in question) – Simon Fox Mar 28 '15 at 18:28
The second part of the solution doesn't work. During initialization, the selection is changed and the event is fired. Inside the event handler, IsLoaded is true – Kesty Jul 13 '17 at 11:36
The solution for me (in addition to the above) was to set the DataContext in the constructor and not in the window's loaded event handler – Kesty Jul 13 '17 at 15:36

score 1 · Answer 2 · answered Jun 27 '17 at 20:12

I faced a particular situation :

If you are using a pivot, and prematurely firing control is in PivotItem > 0, you will still have the problem.

In that case, it seems this.Loaded() only refers to PivotItem "0", and changing to other PivotItem in the UI will fire events anyway.

In that case, the solution is (with your example) :

cmbBox.Loaded += (s, args) =>
           {
                cmbBox.SelectionChanged += 
                        new SelectionChangedEventHandler(HandleChanged);
           };

XAML ComboBox SelectionChanged Fires OnLoad

2 Answers2

Linked