How to fix "Avoid passing null as the view root" in android?

Question

In my android app, I create a dialog like this:

private void handleEdit() {
    LayoutInflater inflater = getLayoutInflater();
    View dialoglayout = inflater.inflate(R.layout.dialog_gallery, null);

    final AlertDialog d = new AlertDialog.Builder(this)
    .setView(dialoglayout)
    .setTitle(R.string.edit)
    .setNegativeButton(R.string.cancel, null)
    .create();

    CheckBox mainCB = (CheckBox)dialoglayout.findViewById(R.id.main);
    CheckBox usedCB = (CheckBox)dialoglayout.findViewById(R.id.used);
    mainCB.setChecked(image.getIsMain());
    usedCB.setChecked(image.getApproved());

    mainCB.setOnClickListener(new OnClickListener() {
        @Override
        public void onClick(View arg0) {
            if (Network.isNetworkAvailable(GalleryScreen.this)) {
                new Async_update_image_state(GalleryScreen.this, fish, image, !image.getIsMain(), image.getApproved(), false);
                d.dismiss();
            } else {
                Popup.ShowErrorMessage(GalleryScreen.this, R.string.no_internet, false);
            }
        }
    });

    usedCB.setOnClickListener(new OnClickListener() {
        @Override
        public void onClick(View arg0) {
            if (Network.isNetworkAvailable(GalleryScreen.this)) {
                new Async_update_image_state(GalleryScreen.this, fish, image, false, !image.getApproved(), true);
                d.dismiss();
            } else {
                Popup.ShowErrorMessage(GalleryScreen.this, R.string.no_internet, false);
            }
        }
    });

    d.show();
}

But I get a warning on View dialoglayout = inflater.inflate(R.layout.dialog_gallery, null); underlining the null.

Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

What does this mean and how can I fix it?

Thanks.

http://stackoverflow.com/questions/24832497/avoid-passing-null-as-the-view-root-need-to-resolve-layout-parameters-on-the-in — Al Lelopath, Dec 26 '14 at 22:50
http://stackoverflow.com/questions/26404951/avoid-passing-null-as-the-view-root-warning-when-inflating-view-for-use-by-ale — Al Lelopath, Dec 26 '14 at 22:51
In this case it's OK to pass null. Add a `@SuppressLint` annotation so it's not bugging you. — Eugen Pechanec, Dec 27 '14 at 15:00

score 13 · Answer 1 · answered Mar 05 '15 at 21:15

13

this works for me

View.inflate(getActivity(), R.layout.dialog, null);

without any warnings nor errors.

answered Mar 05 '15 at 21:15

Leebeedev

2,126
22
31

this is the correct answer according to http://stackoverflow.com/a/26596164/1708390 – Bugs Happen Aug 23 '15 at 17:58

score 8 · Answer 2 · answered Dec 26 '14 at 22:57

When inflating a layout for use in a dialog, You can safely pass null here and ignore the warning.

From This Link

The issue here is that AlertDialog.Builder supports a custom view, but does not provide an implementation of setView() that takes a layout resource; so you must inflate the XML manually. However, because the result will go into the dialog, which does not expose its root view (in fact, it doesn’t exist yet), we do not have access to the eventual parent of the layout, so we cannot use it for inflation. It turns out, this is irrelevant, because AlertDialog will erase any LayoutParams on the layout anyway and replace them with match_parent.

I'd like to use @SuppressWarnings for this but don't know what to use; any ideas? - edit - Found it, @SuppressWarnigns("InflateParams") — linuxgnuru, Mar 29 '17 at 10:10

Ojonugwa Jude Ochalifu · Answer 3 · 2015-07-13T20:31:29.847

2

Instead of :

inflater.inflate(R.layout.dialog_gallery, null);

do:

inflater.inflate(R.layout.dialog_gallery, parent, false);

Using a @SuppressLint annotation as suggested by Eugen in the comment above might "suppress" the warning, but it doesn't solve the problem.Using null as an argument for the ViewGroup will cause you problems in the future.

edited Jul 13 '15 at 20:31

answered Jul 13 '15 at 20:25

Ojonugwa Jude Ochalifu

26,627
26
120
132

score 0 · Answer 4 · answered Dec 26 '14 at 22:58

0

Instead of

inflater.inflate(R.layout.dialog_gallery, null);

try

inflater.inflate(R.layout.dialog_gallery, null, false);

It will not attach view to the parent that is null in your case.

See details on Android Reference

answered Dec 26 '14 at 22:58

ivkil

414
1
4
11

1

This is meaningless, because if you look the Android's source code you'll see this implementation: `public View inflate(int resource, ViewGroup root) { return inflate(resource, root, root != null); }`. I mean, sooner or later it will do the same effect exactly. – Joaquin Iurchuk Jul 27 '15 at 18:32

How to fix "Avoid passing null as the view root" in android?

4 Answers4