Laravel undefined variable ID Controller

Question

I am getting below error:

ErrorException (E_UNKNOWN) Undefined variable: id

below is my code, It is from "Controller"

public function show($id)
 {
  if(Auth::user()) {
   $message = Message::where(function($query) {
    $query->where('from_user', '=', Auth::user()->username)->where('id', '=', $id);
   })->orWhere(function($query) {
    $query->where('from_user', '=', Auth::user()->username)->where('id', '=', $id);
   });
   if($message == null) {
    return Redirect::action('MessageController@index');
   }
   return View::make('view', ['message' => $message, 'active' => 'none']);
  }
 }

Update: My Route is : Route::get('/message/{id}', 'MessageController@show')->before('auth');

I could not understand, what i am messing with up, I have already passed $id in function argument.

When you call `show` are you sure that the `$id` parameter is not null? — ecnepsnai, Dec 29 '14 at 04:27
Your route should be like this Route::get('show/{id}', 'YourController@show'); — Faruk Omar, Dec 29 '14 at 04:32
I don;t know why skids think, they are genius and rates -1 , where answer is some real missing thing, that they are not aware of either. — user3767643, Dec 29 '14 at 08:43

score 1 · Accepted Answer · edited May 23 '17 at 12:28

No, you didn't.
Variable $id is passed to the function show() while you trying to use it inside lambda function passed to the where()/orWhere() method. If you wish to use inside lambda function variable from outer scope you should use use($variableName) construct.

Instead of function($query) { use function($query) use($id) {

Relate answer about use: https://stackoverflow.com/a/8403958/882813
Bear in mind variable early binding.

Laravel undefined variable ID Controller

1 Answers1