php Switch vs If elseif

Question

I'm just wondering if I should use 'Switch' or 'If...else if' in php. (Sample code blow). I've had a google search, but the articles I've read have all been a little old. I also wondered if it's sensible to do what I'm doing in a Switch statement.

switch ( $name ) {
    case 'name1': 
        $data['pageName'] = 'name1';
        $data['pageTitle'] = 'Name 1';
        $this->view('name1/index', $data);
        break;
     case 'name2': 
        $data['pageName'] = 'name2';
        $data['pageTitle'] = 'Name 2';
        $this->view('name2/index', $data);
        break;
     case 'name3': 
        $data['pageName'] = 'name3';
        $data['pageTitle'] = 'Name 3';
        $this->view('name3/index', $data);
        break;
     case 'name4': 
        $data['pageName'] = 'name4';
        $data['pageTitle'] = 'Name 4';
        $this->view('name4/index', $data);
        break;
    default:
        $data['pageName'] = 'default';
        $data['pageTitle'] = 'Default';
        $this->view('default/index', $data);
}



if( $name = 'name1' ) { 
    $data['pageName'] = 'name1';
    $data['pageTitle'] = 'Name 1';
    $this->view('name1/index', $data);
} else if( $name = 'name2' ) { 
    $data['pageName'] = 'name2';
    $data['pageTitle'] = 'Name 2';
    $this->view('name2/index', $data);
} else if( $name = 'name3' ) { 
    $data['pageName'] = 'name3';
    $data['pageTitle'] = 'Name 3';
    $this->view('name3/index', $data);
} else if( $name = 'name4' ) { 
    $data['pageName'] = 'name4';
    $data['pageTitle'] = 'Name 4';
    $this->view('name4/index', $data);
} else {
    $data['pageName'] = 'default';
    $data['pageTitle'] = 'default';
    $this->view('default/index', $data);
}

I use the switch when I have multiple elseif, only for a better readability. I'll let the others say if there is any performance gain — Ebpo, Jan 15 '15 at 15:49
Neither. Your code structure and repetition call for an array map. — mario, Jan 15 '15 at 15:49

Steve · Accepted Answer · 2015-01-15T15:59:21.050

5

You are repeating yourself a lot, instead you can use an array, isset and a single if statement:

$names = [
           'name1'   => 'Name 1',
           'name2'   => 'Name 2',
           'name3'   => 'Name 3',
           'name4'   => 'Name 4',
           'default' => 'default'
];

$name = isset($names[$name]) ? $name : 'default';

$data['pageName'] = $name;
$data['pageTitle'] = $names[$name];

$this->view($name . '/index', $data);

edited Jan 15 '15 at 15:59

answered Jan 15 '15 at 15:50

Steve

20,703
5
41
67

What a difference from this to op's code, +1! – hlscalon Jan 15 '15 at 15:55

score 0 · Answer 2 · edited May 23 '17 at 11:57

0

I definitely agree with Steve's suggestion above, but if the code was just for example, it doesn't really matter if you use if/else or switch/case. It's all a matter of preference. Here's another question asked that goes into details about performance: Performance: if else vs switch, while vs for, for each vs for, print vs printf

edited May 23 '17 at 11:57

Community

1
1

answered Jan 15 '15 at 15:58

cyram

820
8
22

See also http://phpbench.com/ – Charlotte Dunois Jan 15 '15 at 16:03

php Switch vs If elseif

2 Answers2