1
public class Employee {

private String firstName;
private String lastName;
private int age;

public Employee(String firstName, String lastName, int age) {
    super();
    this.firstName = firstName;
    this.lastName = lastName;
    this.age = age;
}

public boolean equals(Employee s) {
    if (this.firstName==s.firstName  && this.lastName == s.lastName) { //Line 1
        return true;
    }
    return false;
}

public static void main(String agrs[]) {

    Employee e1 = new Employee("Jon", "Smith", 30);
    Employee e2 = new Employee("Jon", "Smith", 35);

    System.out.println(e1.equals(e2));
}

}

Line 1 returned true while comparing two Strings with == operator.I thought "Jon" and "Smith" of e1 and e2 will be having two different references(memory location).

What concept is taking care of "Jon" and "Smith" of e1 and e2 to have same references?(String caching??! or Is it just coincidental?)

user104309
  • 690
  • 9
  • 20
  • 1
    More details on intern method.. http://stackoverflow.com/questions/1855170/when-should-we-use-intern-method-of-string-on-string-constants – Sankar Ramasamy Jan 18 '15 at 14:34

1 Answers1

1

This is because of string interning. The string literals "Jon" and "Smith" are compiled into the same string and saved in the string constant pool by the compiler. Hence in this case, both constructors would reference the same instance.

You can see the difference using the below:

Employee e1 = new Employee("Jon", "Smith", 30);
Employee e2 = new Employee("Jon", "Smith", 35);
Employee e3 = new Employee(new String("Jon"), new String("Smith"), 35);

System.out.println(e1.equals(e2));  // true
System.out.println(e1.equals(e3));  // false
M A
  • 71,713
  • 13
  • 134
  • 174
  • While comparing Strings of some Custom Class(here Employee),is it better to use == than .equals() because I think == will be faster? – user104309 Jan 18 '15 at 19:04
  • @user104309 No it's always better to use `.equals` for comparing strings. Normally, don't rely on string interning to compare. – M A Jan 19 '15 at 13:48