Passing Multiple Arguments to a function

Question

function sched_exists($cl_id, $teacher_id, $student_id) {
    $cl_id;
    $teacher_id;
    $student_id;
    return (mysql_result(mysql_query("SELECT COUNT(`sched_id`) FROM `sched` WHERE `class_id` = '$cl_id' AND `teacher_id` = '$teacher_id' AND `stduent_id` = '$student_id'"), 0) == 1) ? true : false; or die(mysql_error());
}

Can you tell me if my code is right? I get this error

Parse error: syntax error, unexpected 'or' (T_LOGICAL_OR) in C:\xampp\htdocs\GradingExpress\admin\core\functions\users.php on line 4"

**Danger**: You are using [an **obsolete** database API](http://stackoverflow.com/q/12859942/19068) and should use a [modern replacement](http://php.net/manual/en/mysqlinfo.api.choosing.php). You are probably **vulnerable to [SQL injection attacks](http://bobby-tables.com/)** that a modern API would make it easier to [defend](http://stackoverflow.com/questions/60174/best-way-to-prevent-sql-injection-in-php) yourself from. — Quentin, Jan 19 '15 at 09:22
Dang! Please don't chain function calls like this, it makes your code non-human parseable... (nor machine parseable, apparently :) — RandomSeed, Jan 19 '15 at 11:20

score 0 · Answer 1 · answered Jan 19 '15 at 09:22

0

You have or die() after the semicolon which isn't allowed. You can remove that, mysql_error can't be there.

return (mysql_result(mysql_query("SELECT COUNT(`sched_id`) FROM `sched` WHERE `class_id` = '$cl_id' AND `teacher_id` = '$teacher_id' AND `stduent_id` = '$student_id'"),0)==1) ? true : false;

answered Jan 19 '15 at 09:22

pavel

26,538
10
45
61

What about my where clause? is it okay? – Albert Saludaga Jan 19 '15 at 09:25
@AlbertSaludaga: there is only typo in `stduent_id` (it should be probably `student_id`), no other problem see there. – pavel Jan 19 '15 at 09:26

Passing Multiple Arguments to a function

1 Answers1