Lint error within loop on function

Question

Im using the following code which works and my question how should I write it better,since when I use EsLint I got red message that saying that dont make function without loop,currently Im new to JS so I dont know how to do that better...

    for (var i = 0; i < allChildren.length; i++) {
        allChildren[i].attachChange(function(){
                this.getChecked() ? nSelectedChildren+=1 : nSelectedChildren-=1;
                if(nSelectedChildren === 0){
                    oParent.toggle("Unchecked");
                }
                else if(nSelectedChildren === allChildren.length){
                    oParent.toggle("Checked");
                }
                else{
                    oParent.toggle("Mixed");
                }
            }
        );

If this code works, it may be a better fit over on [Code Review](http://codereview.stackexchange.com/) — James Thorpe, Jan 20 '15 at 13:00
@Funonly- this is the case ,any idea how to write it better? — John Jerrby, Jan 20 '15 at 13:18
@Funonly-I must use it :( ,there is other way to do that ? better way... ? — John Jerrby, Jan 20 '15 at 13:19

score 1 · Answer 1 · answered Jan 20 '15 at 13:18

What EsLint meant what it should be, i think, is:

function foo(){
    this.getChecked() ? nSelectedChildren+=1 : nSelectedChildren-=1;
    if(nSelectedChildren === 0){
        oParent.toggle("Unchecked");
    }
    else if(nSelectedChildren === allChildren.length){
        oParent.toggle("Checked");
    }
    else{
        oParent.toggle("Mixed");
    }
}

for (var i = 0; i < allChildren.length; i++) {
    allChildren[i].attachChange(foo);
}

Don't define functions within loops

Lint error within loop on function

1 Answers1