C++ Inheritance constructor override

Question

I have a piece of code that applies a lot of computations to a set of data. This data is organized in a class, and consists mostly of scalars and arrays of floats and doubles. The problem is that the variables on the class depends on the input file structure, i.e., file A may have 10 scalar variables and B may have 20 arrays. How can I create an abstraction to deal with this heterogeneous data?

I thought of creating a class Data and a specific one for each different input, A and B, which inherit from Data. However I've a big problem:

In the code I only want to address the dataset as the Data class, in a

vector<Data> datas;
Data d = new Data();
datas.push_back(d);

and I don't want to do

vector<Data> datas;
Data d = new A();
datas.push_back(d);

but that implies that the parent class will access the child class for the variables, constructors, etc, which I don't now if it's possible (note that the application only reads file A or B, not both in the same execution, I have no problem of setting which at compile time and only add the class A or B to the code)

P.S.: In the original code, written by non computer scientists, they would create the Data class and and an #include "variables.cxx" in its declaration. It obviously works but should be avoided at all costs...

how do you differentiate between scalars and arrays in the Input file? — Rubix Rechvin, Jan 23 '15 at 15:08
unrelated: `Data d = new Data();` is wrong, just use `Data d;`, or, if you want polymorphic behaviour, use a pointer (or smart pointer) like `Data* d = new A();` or `std::shared_ptr d = std::make_shared();` — vsoftco, Jan 23 '15 at 15:09
What about having your class have two vectors? One for scalars data and another for array data? If you can parse what you're reading in, then you can create an object you want and then push it onto the appropriate vector. — Rubix Rechvin, Jan 23 '15 at 15:10
Would it be acceptable to have a factory to create `Data` objects that creates the specific type depending on...well...whatever it depends on. — Chris Drew, Jan 23 '15 at 15:11

score 0 · Answer 1 · answered Jan 23 '15 at 15:15

You need an array of pointers to the base class. This allows vector to work with one type of fixed size (pointer to base class), but that type represents all your objects of different size.

std::vector<base*> datas;
datas.push_back(new derived);

If you have c++11 then vector can manage the memory for you:

std::vector<std::unique_ptr<base>> datas;
datas.push_back(std::make_unique<derived>());

score 0 · Answer 2 · answered Jan 23 '15 at 15:45

Use dynamic binding in C++ which allow you access functions(except constructor) in child class by pointer of parent type. This is a sample:

class Data
{
public:
    virtual void func() = 0;    
};

class A : public Data
{
public:
    void func();
};

class B : public Data
{
    void func();
};

Then you can process data like this:

vector<Data*> datas;
Data *d = new A();
d->func();//do something, for example read data from files
datas.push_back(d);

Chris Drew · Answer 3 · 2015-01-23T19:27:25.440

Templates

One option, as you said you are happy to choose the type at compile time is to template your code on the data type:

template<typename Data>
void doComputations() {
    std::vector<Data> datas;
    Data d;
    datas.push_back(d);
}

doComputations<A>();

Then you don't need a base Data class just an implicit interface shared by A and B. But this might mean a lot of your code has to be templated which might not be want you want.

Polymorphism

With stack allocated objects

If you want to take advantage of the runtime polymorphic behaviour of a Data base class then you need to store a vector of pointers.

One way of filling the vector would be to have separate vectors that own the A and B and then one vector of Data raw pointers to do the computations on:

std::vector<A> a_datas;
std::vector<B> b_datas;

a_datas.push_back(A{});
a_datas.push_back(A{});
b_datas.push_back(B{});

std::vector<Data*> datas;    
for (auto& a : a_datas)
  datas.push_back(&a);

for (auto& b : b_datas)
  datas.push_back(&b);

doComputations(datas);

With heap allocated objects

Or the more flexible approach is to allocate the objects on the heap and manage them with one vector of smart pointers:

struct Data {
public:
  virtual ~Data(){}
  //...
};

struct A : Data { /* ... */ };
struct B : Data { /* ... */ };

std::unique_ptr<Data> loadData() {
  if ( condition )
    return std::make_unique<A>();
  else
    return std::make_unique<B>();
   }
}

std::vector<std::unique_ptr<Data>> datas;    
datas.push_back(loadData());
datas.push_back(loadData());

doComputations(datas);

C++ Inheritance constructor override

3 Answers3

Templates

Polymorphism

With stack allocated objects

With heap allocated objects

Linked