isset method not working returns nothing

Question

I am trying to map a collection of JSON files into a database but my isset check is not working in my PHP :

    <?php
$con = mysqli_connect("localhost", "root", "", "json_map");
$response = array();
$res = array();
$result = '';

foreach(glob('C:\xampp\htdocs\laravel\awsconfig\app\views\*.json') as $filename)
    {
    $json = file_get_contents($filename);
    if ($json != null)
        {
        $decoded = json_decode($json, true);

        // $decode= var_dump($decoded);
        // $ss=$decode["array"];
        // echo $decoded['number'];

        if (is_array($decoded["configurationItems"]))
            {
            foreach($decoded["configurationItems"] as $configurationItems)

            // for($i=0;$i>sizeof($decoded["configurationItems"]);$i++)

                {
                $cfi = isset($configurationItems["configuration"]) ? $configurationItems["configuration"] : '';
                if (isset($cfi["instanceId"]) && isset($cfi["imageId"]) && isset($cfi["privateDnsName"]) && isset($cfi["publicDnsName"]) && isset($cfi["keyName"]) && isset($cfi["stateTransitionReason"]) && isset($cfi["amiLaunchIndex"]) && isset($cfi["instanceType"]) && isset($cfi["launchTime"]) && isset($cfi["kernelId"]) && isset($cfi["subnetId"]) && isset($cfi["vpcId"]) && isset($cfi["privateIpAddress"]) && isset($cfi["architecture"]) && isset($cfi["rootDeviceType"]) && isset($cfi["rootDeviceName"]) && isset($cfi["virtualizationType"]) && isset($cfi["clientToken"]) && isset($cfi["sourceDestCheck"]) && isset($cfi["hypervisor"]) && isset($cfi["ebsOptimized"]))
                    {
                    $instanceId = $configurationItems["configuration"]["instanceId"];
                    echo "instanceId:", $instanceId, "<br />";
                    $imageId = $configurationItems["configuration"]["imageId"];
                    echo "imageId:", $imageId, "<br />";
                    $privateDnsName = $configurationItems["configuration"]["privateDnsName"];
                    echo "privateDnsName:", $privateDnsName, "<br />";
                    $publicDnsName = $configurationItems["configuration"]["publicDnsName"];
                    echo "publicDnsName:", $publicDnsName, "<br />";
                    $keyName = $configurationItems["configuration"]["keyName"];
                    echo "keyName:", $keyName, "<br />";
                    $stateTransitionReason = $configurationItems["configuration"]["stateTransitionReason"];
                    echo "stateTransitionReason:", $stateTransitionReason, "<br />";
                    $amiLaunchIndex = $configurationItems["configuration"]["amiLaunchIndex"];
                    echo "amiLaunchIndex:", $amiLaunchIndex, "<br />";
                    $instanceType = $configurationItems["configuration"]["instanceType"];
                    echo "instanceType:", $instanceType, "<br />";
                    $launchTime = $configurationItems["configuration"]["launchTime"];
                    echo "launchTime:", $launchTime, "<br />";
                    $kernelId = $configurationItems["configuration"]["kernelId"];
                    echo "kernelId:", $kernelId, "<br />";
                    $subnetId = $configurationItems["configuration"]["subnetId"];
                    echo "subnetId:", $subnetId, "<br />";
                    $vpcId = $configurationItems["configuration"]["vpcId"];
                    echo "vpcId:", $vpcId, "<br />";
                    $privateIpAddress = $configurationItems["configuration"]["privateIpAddress"];
                    echo "privateIpAddress:", $privateIpAddress, "<br />";
                    $architecture = $configurationItems["configuration"]["architecture"];
                    echo "architecture:", $architecture, "<br />";
                    $rootDeviceType = $configurationItems["configuration"]["rootDeviceType"];
                    echo "rootDeviceType:", $rootDeviceType, "<br />";
                    $rootDeviceName = $configurationItems["configuration"]["rootDeviceName"];
                    echo "rootDeviceName:", $rootDeviceName, "<br />";
                    $virtualizationType = $configurationItems["configuration"]["virtualizationType"];
                    echo "virtualizationType:", $virtualizationType, "<br />";
                    $clientToken = $configurationItems["configuration"]["clientToken"];
                    echo "clientToken:", $clientToken, "<br />";
                    $sourceDestCheck = $configurationItems["configuration"]["sourceDestCheck"];
                    echo "sourceDestCheck:", $sourceDestCheck, "<br />";
                    $hypervisor = $configurationItems["configuration"]["hypervisor"];
                    echo "hypervisor:", $hypervisor, "<br />";
                    $ebsOptimized = $configurationItems["configuration"]["ebsOptimized"];
                    echo "ebsOptimized:", $ebsOptimized, "<br />";
                    $result = mysqli_query($con, "INSERT INTO     configuration(instance_id, image_id, private_dns_name, public_dns_name, key_name, state_transition_reason, ami_launch_index, instance_type, launch_time, kernel_id, subnet_id, vpc_id, private_ip_address,architecture, root_device_type, root_device_name, virtualisation_type, client_token, source_dest_check, hypervisor, ebs_optimised)


VALUES('$instanceId','$imageId', '$privateDnsName' , '$publicDnsName', '$keyName', '$stateTransitionReason', '$amiLaunchIndex', '$instanceType', '$launchTime', '$kernelId', '$subnetId', '$vpcId', '$privateIpAddress', '$architecture', '$rootDeviceType', '$rootDeviceName', '$virtualizationType', '$clientToken', '$sourceDestCheck', '$hypervisor', '$ebsOptimized')") or die("Insert Failed " . ((is_object($con)) ? mysqli_error($con) : (($___mysqli_res = mysqli_connect_error()) ? $___mysqli_res : false)));;
                    } // check if row inserted or not
                if ($result)
                    {

                    // successfully inserted into database

                    $response["code"] = 1;
                    $response["message"] = "successfully updated config table ";

                    // echoing JSON response

                    echo json_encode($response);
                    }
                  else
                    {

                    // failed to insert row

                    $response["code"] = 2;
                    $response["message"] = "Oops! An error occurred.";

                    // echoing JSON response

                    echo json_encode($response);
                    }
                }
            }
        }
    }

?>

when I use

$cfi = isset($configurationItems["configuration"]) ? $configurationItems["configuration"] : '';

I get oops an error occured no explanation of error

when I use

$cfi = $configurationItems ["configuration"];

I get as above plus undefined index configuration (the error)

Rewrite this code, do it properly this time, and don't blame `isset` (as in: don't say it doesn't work) when the real problem is you. Honestly, without wanting to be rude, but this code is terrible (injection vulnerabilities, `glob` for all .json files, misusing `isset` on what is probably an empty string, horrible spaghetti code, _and_ mixing `echo` of markup in with DB stuff... just don't ever do that — Elias Van Ootegem, Jan 27 '15 at 13:29

score 0 · Answer 1 · edited May 23 '17 at 11:57

0

isset() will return FALSE if testing a variable that has been set to NULL.

For more details refer link

edited May 23 '17 at 11:57

Community

1
1

answered Jan 27 '15 at 13:16

khanz

205
1
9

And this is suppose to answer the question, how? – Jonast92 Jan 27 '15 at 13:19
this is neither helpful nor correct. `isset` is also used to check if an array of object has a certain key/property defined, without raising notices – Elias Van Ootegem Jan 27 '15 at 13:22
@RichardHewitt: I'm sorry, I saw that and it caused me to delete my answer. Some of the reasons I've put in a comment below your question – Elias Van Ootegem Jan 27 '15 at 13:30
@EliasVanOotegem I never for a minute thought it was anything other than human error will take comments onboard thanks – Richard Hewitt Jan 27 '15 at 13:34

score 0 · Answer 2 · answered Jan 27 '15 at 13:46

Instead of having to use isset for every single key that is required for your criteria, you can build a validation array with the required keys and then check if your designated array contains all those keys.

$required_keys = ['instanceId',
                  'imageId',
                  'privateDnsName',
                  'publicDnsName',
                  'keyName',
                  'stateTransitionReason',
                  'amiLaunchIndex',
                  'instanceType',
                  'launchTime',
                  'kernelId',
                  'subnetId',
                  'vpcId',
                  'privateIpAddress',
                  'architecture',
                  'rootDeviceType',
                  'rootDeviceName',
                  'virtualizationType',
                  'clientToken',
                  'sourceDestCheck',
                  'hypervisor',
                  'ebsOptimized'];

.........

if (isset($configurationItems['configuration'])) {
   if (count(array_intersect_ukey($configurationItems['configuration'], array_flip($required_keys), function($a, $b) {
                                                                                                       return -1 * ($a < $b) + ($a > $b);
                                                                                                    })) === count($required_keys)) {
       .....
   }
}

Keep it simple: `if (empty(array_diff($requiredKeys, array_keys($configurationItems['configuration']))))` will do, without using `array_flip` + `array_intersect_ukey` + Closure... + `count` — Elias Van Ootegem, Jan 27 '15 at 14:24
That's subject to debate. The PHP implementation of closures are, IMHO, not that nice _and_ there's no need for them here => KISS is the way to go — Elias Van Ootegem, Jan 27 '15 at 14:32

score 0 · Accepted Answer · answered Jan 28 '15 at 09:04

0

bracket was in wrong place used

$cfi = isset($configurationItems["configuration"]) ? $configurationItems["configuration"] : '';`

works a treat

answered Jan 28 '15 at 09:04

Richard Hewitt

345
1
5
22

isset method not working returns nothing

3 Answers3