Insert form into MySQL

Question

I just started with PHP and SQL and wanted to insert a submitted form into a mysql table. I got a lot of things from already answered questions here, but now encountered the problem that the data is not inserted into the table and I do not get any errormessage. Checking it with affected_rows results in -1 but I am unable to find my mistake.

The form

<form method="post" action="anmeld.php">
<table>
    <tr>
        <td>
            Familie/Name:
        </td><td>
            <input type="text" name="name" required>
        </td>
    </tr>

    <tr>
        <td>
            Wir kommen  Ja&nbsp;<input type="radio" name="anwesend" value="ja" checked>
            &nbsp;Nein&nbsp;<input type="radio" name="anwesend" value="nein">
        </td>
    </tr>

    <tr>
        <td>
            Wir sind 
        </td>
        <td><input type="number" name="adult">&nbsp;Erwachsene.
        </td>
    </tr>
    <tr>
        <td><br> Unsere Kinder sind<br>
            Kind <br>Kind<br>Kind<br>Kind
        </td>
        <td><br><br>
            <input type="number" name="child1"> Jahre alt. <br><input type="number" name="child2"> Jahre alt. <br><input type="number" name="child3"> Jahre alt. <br><input type="number" name="child4"> Jahre alt.
        </td>
    </tr>

    <tr>
        <td>
            <input type="submit" name="submit" value="Abschicken">
        </td>
    </tr>

</table>

php insert

    <?php

$mysqli = new mysqli("127.0.0.1", "user", "userpw", "dbname");
if ($mysqli->connect_errno) {
    echo "Failed to connect to MySQL: (" . $mysqli->connect_errno . ") " . $mysqli->connect_err;
}

if (!empty($_POST["submit"])) {
    $familie = $_POST["name"];
    $anwesend = $_POST["anwesend"];
    $adult = $_POST["adult"];
    $child1 = $_POST["child1"];
    $child2 = $_POST["child2"];
    $child3 = $_POST["child3"];
    $child4 = $_POST["child4"];

    $sql = "INSERT INTO 'guests' ('id', 'familie', 'anwesend', 'adult', 'child1', 'child2', 'child3', 'child4')
 VALUES ('', '$familie', '$anwesend', '$adult', '$child1', '$child2', '$child3', '$child4')";

    $mysqli->query($sql);

    printf("Affected rows (INSERT): %d\n", $mysqli->affected_rows);
}
?>

I think it's something really obvious, I simply overlook but I hope that you guys could help me.

EDIT: yeah it's been the ` and '. Now works fine. Thank you guys

is id auto increment/primary key? if so, you might want to remove the field all together as well as the `'',` in values. Are any of the other fields numeric values? if so they don't need apostrophe's around them. Also look at prepared statements vs straight queries to increase security. have you tried echoing the error if it exists? oh and `'guests'` shouldn't have the apostrophes either — Dave Goten, Jan 28 '15 at 14:44
Protip example: `$sql = "Your SQL statement here"; $result = mysqli_query($sql) or trigger_error("Query Failed! SQL: $sql - Error: ".mysqli_error(), E_USER_ERROR);` which you're not doing. Or simply `echo $mysqli->error;` after your query. — Funk Forty Niner, Jan 28 '15 at 15:03

score 0 · Answer 1 · edited Jan 28 '15 at 16:15

0

You are using the incorrect identifiers for your table and columns, being quotes.

Remove the quotes around your table and columns:

INSERT INTO guests (id, familie, anwesend, adult, child1, child2, child3, child4)

For more information on identifier qualifiers, consult:

http://dev.mysql.com/doc/refman/5.0/en/identifier-qualifiers.html

Use echo $mysqli->error; after your query, which would have signaled the syntax errors.

edited Jan 28 '15 at 16:15

Funk Forty Niner

74,450
15
68
141

answered Jan 28 '15 at 14:49

Rafael

7,605
13
31
46

Question is, did "you" try it? – Funk Forty Niner Jan 28 '15 at 14:51
lol I don't need to. I know it's going to fail. – Funk Forty Niner Jan 28 '15 at 14:53
You also should look at the link I closed the question with. You too will learn something ;-) – Funk Forty Niner Jan 28 '15 at 14:54
oh darn that's a stupid mistake... thank you a lot. This is something helpfull for my next projects – Keksekopf Jan 28 '15 at 15:06
Your edit is even worse. Read and study http://stackoverflow.com/questions/11321491/when-to-use-single-quotes-double-quotes-and-backticks – Funk Forty Niner Jan 28 '15 at 15:06
@Keksekopf I can't see how this answer works; it's even worse and will error out something fierce. Who are you thanking, him or me for giving you the right link to consult with? – Funk Forty Niner Jan 28 '15 at 15:07
1

Edit to the answer made as per the original post http://stackoverflow.com/revisions/28195198/1 being incorrect. Hence the comments above in regards to this. – Funk Forty Niner Jan 28 '15 at 16:17

Insert form into MySQL

1 Answers1