Can't get mysql_query to return any values that exist in the database

Question

I'm using the following snippet:

mysql_connect($host,$user,$password);
$sql = "SELECT FROM ec_opps WHERE id=" . $_GET["UPDATE"];
$item = mysql_query($sql);
mysql_close();
print_r($item);

To try and retrieve data based on the UPDATE value. This value prints to the page accurately, and I know the IDs I'm requesting exist in the database. The print_r($item) function returns no result, not even an empty array, so I'm confused as to where I'm going wrong.

I know it isn't best practise to use MySQL like this, but I'm doing it for a reason.

mysql_* functions are unsafe and deprecated. Please, use mysqli_* or PDO. http://php.net/manual/en/book.pdo.php — Vick, Jan 29 '15 at 06:31

score 0 · Answer 1 · answered Jan 29 '15 at 06:33

0

Replace with this code

 $sql = "SELECT * FROM ec_opps WHERE id=" . $_GET["UPDATE"];

answered Jan 29 '15 at 06:33

vignesh.D

766
4
18

score 0 · Answer 2 · answered Jan 29 '15 at 06:34

0

You are missing * in your query.

You need to use: SELECT * FROM instead of SELECT FROM

answered Jan 29 '15 at 06:34

Muhammad Bilal

2,106
1
15
24

score 0 · Answer 3 · answered Jan 29 '15 at 06:34

0

There is a syntax error in the query. It is missing *. Try with -

$sql = "SELECT * FROM ec_opps WHERE id='" . $_GET["UPDATE"] . "'";

Please avoid using mysql. Try to use mysqli or PDO. mysql is deprecated now.

answered Jan 29 '15 at 06:34

Sougata Bose

31,517
8
49
87

score 0 · Accepted Answer · edited May 23 '17 at 12:28

You're missing columns to be selected in your SELECT query, or you can select all by putting *, which means selecting all column.

$sql = "SELECT * FROM ec_opps WHERE id='" . $_GET["UPDATE"]."'";

Your query is very prone to SQL injections.

You should refrain from using MySQL. It's deprecated already. You should be at least using MySQLi_* instead.

<?php
/* ESTABLISH CONNECTION */
$mysqli = new mysqli($host, $user, $password, $database);

if (mysqli_connect_errno()) {
    printf("Connect failed: %s\n", mysqli_connect_error());
    exit();
}

$query = "SELECT column1, column2 FROM ec_opps WHERE id=?"; /* REPLACE NEEDED COLUMN OR ADD/REMOVE COLUMNS TO BE SELECTED */

if ($stmt = $mysqli->prepare($query)) {

    $stmt->bind_param("s", $_GET["UPDATE"]); /* BIND GET VALUE TO THE QUERY */
    $stmt->execute(); /* EXECUTE QUERY */
    $stmt->bind_result($column1,$column2); /* BIND RESULTS */

    while ($stmt->fetch()) { /* FETCH RESULTS */
        printf ("%s (%s)\n", $column1, $column2);
    }

    $stmt->close();
}

$mysqli->close();

?>

Can't get mysql_query to return any values that exist in the database

4 Answers4