Attempt to add annotation to defrecord defined class in macro

Question

I'm attempting to create a macro similar to the Quartzite defjob macro that creates the Job class with the @DisallowConcurrentExecution annotation added to it. The code works from the repl, but not inside the macro.

This works...

user=> (defrecord ^{DisallowConcurrentExecution true} YYY []
  #_=>   org.quartz.Job
  #_=>   (execute [this context]
  #_=>            (println "whoosh!")))
user.YYY
user=> (seq (.getAnnotations YYY))
(#<$Proxy3 @org.quartz.DisallowConcurrentExecution()>)

...but this does not.

(defmacro defncjob
  [jtype args & body]
  `(defrecord ^{DisallowConcurrentExecution true} ~jtype []
              org.quartz.Job
              (execute [this ~@args]
                ~@body)))

After Rodrigo's suggestion, here is a way to make it work.

(defmacro defdcejob
  [jtype args & body]
  `(defrecord ~(vary-meta jtype assoc `DisallowConcurrentExecution true) []
     org.quartz.Job
     (execute [this ~@args]
       ~@body)))

could you run `(macroexpand-1 '(defncjob XXX [context] (println "whooosh"))) and include the result ? (this is the first step in *every* macro problem) — Arthur Ulfeldt, Jan 30 '15 at 02:02
You can't use a reader macro (^) inside a macro. Take a look here: http://stackoverflow.com/questions/7754429/clojure-defmacro-loses-metadata — Rodrigo Taboada, Jan 30 '15 at 03:45
@RodrigoTaboada Please put that in an answer so I can accept it. Thanks — BillRobertson42, Jan 30 '15 at 13:34

score 1 · Accepted Answer · edited May 23 '17 at 12:28

1

You can't use the ^ reader macro inside macros. Take a look at this similar question.

edited May 23 '17 at 12:28

Community

1
1

answered Jan 30 '15 at 13:41

Rodrigo Taboada

2,727
4
24
27

Attempt to add annotation to defrecord defined class in macro

1 Answers1