Spinner item does not work

Question

I ahve an application with a spinner drop down menu. When I tap Admin from spinner drop down menu it does not go to Admin.class. And same with Teacher, when I tap Teacher from spinner drop down menu it does not go to Student.class.\

My code:

public class Home extends Activity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {

        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_home);

        String[] sp1 = getResources().getStringArray(R.array.Level);
        Spinner spinner = (Spinner)findViewById(R.id.spinner);
        ArrayAdapter<String> adapter = new ArrayAdapter<String>(this,android.R.layout.simple_spinner_item,sp1);
        spinner.setAdapter(adapter);

        spinner.setOnItemSelectedListener(new OnItemSelectedListener() {

            @Override
            public void onItemSelected(AdapterView<?> parent, View view, int position, long id) {

                String s = parent.getItemAtPosition(position).toString();
                if(s=="Admin")
                    startActivity(new Intent(Home.this,Admin.class));
                if(s=="Teacher")
                    startActivity(new Intent(Home.this,Student.class));   
            }

            public void onNothingSelected(AdapterView<?> arg0) {
                // TODO Auto-generated method stub
            }
        });    
    }
}

Possible duplicate of [Difference between Equals/equals and == operator?](http://stackoverflow.com/questions/971954/difference-between-equals-equals-and-operator) and [How do I compare strings in Java?](http://stackoverflow.com/q/513832/608639) — jww, Feb 02 '15 at 01:53

Rohit5k2 · Answer 1 · 2015-02-03T14:18:13.177

Use the firstString.equals(secondString) function to compare strings, not the == operator.

The function checks the actual contents of the string, the == operator checks whether the references to the objects are equal. Note that string constants are usually "interned" such that two constants with the same value can actually be compared with ==, but it's better not to rely on that.

Do it this way

@Override
public void onItemSelected(AdapterView<?> parent, View view,
                int position, long id) {
    String s = parent.getItemAtPosition(position).toString();
    if(s.equals("Admin"))
        startActivity(new Intent(Home.this,Admin.class));
    if(s.equals("Teacher"))
        startActivity(new Intent(Home.this,Student.class));
}

EDIT

public class Home extends Activity {
private boolean spinnerAutoSelectionDone = false;
@Override
protected void onCreate(Bundle savedInstanceState) {

    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_home);

    String[] sp1 = getResources().getStringArray(R.array.Level);
    Spinner spinner = (Spinner)findViewById(R.id.spinner);
    ArrayAdapter<String> adapter = new ArrayAdapter<String>(this,android.R.layout.simple_spinner_item,sp1);
    spinner.setAdapter(adapter);

    spinner.setOnItemSelectedListener(new OnItemSelectedListener() {

        @Override
        public void onItemSelected(AdapterView<?> parent, View view, int position, long id) {

            if(!spinnerAutoSelectionDone){
                spinnerAutoSelectionDone = true;
                return;
            }

            String s = parent.getItemAtPosition(position).toString();
            if(s.equals("Admin"))
                startActivity(new Intent(Home.this,Admin.class));
            if(s.equals("Teacher"))
                startActivity(new Intent(Home.this,Student.class));   
        }

        public void onNothingSelected(AdapterView<?> arg0) {
            // TODO Auto-generated method stub
        }
    });    
}
}

this code is now working but for Teacher not for Admin – Zohra Rao Feb 03 '15 at 12:08 — Zohra Rao, Feb 03 '15 at 12:08
Check the value you are getting. – Rohit5k2 Feb 03 '15 at 14:18 — Rohit5k2, Feb 03 '15 at 14:18

score 1 · Answer 2 · answered Feb 02 '15 at 01:35

1

use s.eauals() method instead of ==opetator.... because you are comparing for reference here not for values.

answered Feb 02 '15 at 01:35

RajSharma

1,941
3
21
34

i use this ,now from login page it directly go to Student.class and skip Home Class where my spinner is implemented – Zohra Rao Feb 02 '15 at 01:43
Because you are doing it wrong. 0th item selection is automatically called. – Rohit5k2 Feb 02 '15 at 01:55

Spinner item does not work

2 Answers2