getline() with ifstream pointer error?

Question

I have the following code:

void Category:: fillCategories(char** & categories, char** &subset, std::ifstream *input, 
int*&subIndex)
{
    while(!input->eof())
    {
        char buffer[30];
        if (getCatSize()==getCatCapacty())
        {
            resize(categories, getCategoryCapAddress(), 5);
        }
        if (getSubSize()==getSubCap())
        {
            resize(subset, getSubsetCapAddress(), 5, subIndex);
        }
        std::getline(*input,buffer);
    }
}

for some reason

std::getline(*input,buffer);

is giving me an error. Is there anything I can do to fix this?

`std::getline` can't be used with a character array. Use `std::string` instead. — , Feb 10 '15 at 01:45
See also http://stackoverflow.com/questions/5431941/while-feof-file-is-always-wrong about why your `while` expression is wrong. — Thomas Matthews, Feb 10 '15 at 01:47

score 0 · Accepted Answer · answered Feb 10 '15 at 02:09

You should move getline up into the loop condition, and replace while with for, like this:

for (std::string buffer; getline(*input, buffer); )

And of course remove the char[] version of buffer. This way you have a dynamically sized buffer that works with std::getline and uses the correct termination condition.

getline() with ifstream pointer error?

1 Answers1