mysql php UPDATE doesn't work

Question

I would like to change data from my mysql database ... but it does't work.

Here is the script:

<?php
session_start();

$con = mysql_connect("localhost", "...", "...");
mysql_select_db('chat',$con);
$uname = $_SESSION['username'];

mysql_query("UPDATE users SET disabled = 'yes' WHERE userame = $uname");

mysql_close($con);

header("Location: logout.php");

?>

How can I update the data? Thanks for your help!

Do not use `mysql_* functions because these api is deprcated. Use `mysqli_*` or `pdo`. — Jens, Feb 13 '15 at 18:51
Is `userame` a typo? Should column name not be `username` instead? — nishu, Feb 13 '15 at 19:12

score 3 · Answer 1 · edited May 25 '19 at 12:03

3

You forgot to put single quotes around your string value:

mysql_query("UPDATE users SET disabled = 'yes' WHERE username = '$uname'");

FYI, you shouldn't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial.

You may also be open to SQL injections depending on how you obtain the value conained within $_SESSION['username'].

edited May 25 '19 at 12:03

Zoe

27,060
21
118
148

answered Feb 13 '15 at 18:50

John Conde

217,595
99
455
496

First thanks for the answer! But it doesn't work :( Whats else might be wrong? I'm trying to get this to work for hours now – Intera Feb 13 '15 at 18:54
What error do you get? Do you check `mysql_error()`? Have you reviewed the query to make sure it is correct? – John Conde Feb 13 '15 at 18:54
It says " Unknown column 'userame' in 'where clause' " :/ – Intera Feb 13 '15 at 18:59
1

@Intera userame > username missing an "n" in username – E_p Feb 13 '15 at 18:59
As @E_p has pointed out, you misspelled `username` in your query. – John Conde Feb 13 '15 at 19:01

score 0 · Answer 2 · answered Feb 13 '15 at 19:01

0

Change:

mysql_query("UPDATE users SET disabled = 'yes' WHERE userame = $uname");

To:

mysql_query("UPDATE `users` SET `disabled` = 'yes' WHERE `userame` = '$uname'"); // userame might be username.

Add the back tacks around the column names because otherwise you could have an error of using a mysql reserved word. Also the quotes around $uname are important because otherwise it might not be a string.

answered Feb 13 '15 at 19:01

SuperDJ

7,488
11
40
74

lol .... I'm searching the mistake in the script and it's quite simple... Thank you!! – Intera Feb 13 '15 at 19:03

mysql php UPDATE doesn't work

2 Answers2