We have a particularly critical project in one of our solutions and would like any check-ins to that project to be approved by another member of the team. Is this possible?
Asked
Active
Viewed 1,801 times
6
-
Have you had a look around? http://stackoverflow.com/questions/11715017/how-to-force-code-review-before-check-in-in-tfs-2012-rc – Kye Feb 18 '15 at 00:15
-
2The only solution I could see is to have someone check-in on someone else's behalf, which isn't the same as approving a check-in. – macbe Feb 18 '15 at 00:23
-
Which version of TFS? – John Saunders Feb 18 '15 at 00:29
-
1@JohnSaunders TFS Online - it's all done through Visual Studio Online – macbe Feb 18 '15 at 00:38
2 Answers
3
Forcing a code review is not possible at the moment but you could switch to a branching model where merges between the branches are only allowed by the senior developers who perform code reviews.
Although a little drastic, you could even switch to using Git instead of TFVC. Git has support for pull requests where you lock down your master branch and then use the pull requests as a review mechanism.
Wouter de Kort
- 39,090
- 12
- 84
- 103
1
There is currently no support for this within TFS. What you could do is:
- ask the developer to seek a TFS Code Review before each checkin.
- enforce comments on all change sets.
- ask the senior developer to review the change set comments before you label the release / deploy etc
Or if the project is critical devote more time towards pairing.
Kye
- 5,919
- 10
- 49
- 84
-
That's not necessarily true. There are check-in policies to require a code review prior to a check-in. Of course, with VSO, it's not an option because VSO currently doesn't allow for custom check-in policies. – Daniel Mann Feb 18 '15 at 02:18
-
My apologies. There is an unsupported version here. https://visualstudiogallery.msdn.microsoft.com/c476b708-77a8-4065-b9d0-919ab688f078 – Kye Feb 18 '15 at 02:38