Writing output to text file in a class in java?

Question

I'm having an issue of writing output to a text file. I'm not too sure on how to go about it. I've tried to write output by writing something along the lines of- Writer is an object of the printWriter class:

This is trimmed down substantially but it boils down to.

Writer.println(sortRI());

I can't write that statement as the method itself- and all methods in this class I'm trying to write to an output file for are void.

So my question is how do I write output to a text file from my methods which are void- they print out their results via a few print statements. Is there a way I can instantiate a writer and use the writer to print the methods. An example of one of the methods is shown below:

ZipCodeLocation[] data2 = new ZipCodeLocation[];

public class Processor
{
  ...

  public void readData(){

  ...

  }

public void findSpringfield()
{
    System.out.println("------------------------------------------------------------------------");
    System.out.println("SPRINGFIELD ZIP CODES");

    for(int i=0; i < data2.length ; i++)
    {
        if(data2[i].getpostalCity().replaceAll("\"","").contains("SPRINGFIELD"))
        {
          System.out.println(data2[i].getzipCode().replaceAll("\"",""));  //Prints out zipCodes that have Springfield in them
        }
    }
}

Instead of printing the message to System.out in the console, how could I have it write the output of the method to a text file?

Anyone have an idea? Could really use some input. – Ricardo Rigaroni Feb 21 '15 at 00:27 — Ricardo Rigaroni, Feb 21 '15 at 00:27

gknicker · Accepted Answer · 2015-02-21T00:58:03.950

You have asked a very good question, because it describes an instance of a design consideration common to all software.

The topic here is separation of business logic from interfaces. Even more generally, it's a discussion of well-defined responsibilities in an object-oriented program.

Ideally your business logic would return a data structure, which would allow the caller to do anything desired with the result, like write it to a file or display it in a web page.

public List<String> findSpringfield()
{
    List<String> results = new ArrayList<String>();
    for(int i=0; i < data2.length ; i++) {
        if(data2[i].getpostalCity().contains("SPRINGFIELD")) {
            results.add(data2[i].getzipCode().replaceAll("\"",""));  //Collects zipCodes that have Springfield in them
        }
    }
    return results;
}

If that's not an option, at the absolute minimum you would want to modify your methods to accept a PrintStream parameter.

public void findSpringfield(PrintStream out)
{
    out.println("------------------------------------------------------------------------");
    out.println("SPRINGFIELD ZIP CODES");

    for(int i=0; i < data2.length ; i++) {
        if(data2[i].getpostalCity().contains("SPRINGFIELD")) {
            out.println(data2[i].getzipCode().replaceAll("\"",""));  //Prints out zipCodes that have Springfield in them
        }
    }
}

That way you could call it like

findSpringfield(System.out);

Or you could pass it a different PrintStream instance than System.out, one that points to your own file.

Finally, if neither of the above options will work for you, I'm going to tell you how to do something which is very bad practice. You can redirect System.out to a file of your choosing. As I said, this is a terrible idea; use it only as a last resort in a very limited scope.

System.out = new PrintStream("somePath/someFile.txt");

Also, as a design improvement, consider generalizing your findSpringfield method to accept a String postalCity parameter so you can reuse it to find zip codes for other cities.

public List<String> zipsByCity(String postalCity)
{
    // use postalCity to filter results, rather than hardcoded "SPRINGFIELD" string
}

Sorry I just noticed this, gave you that long-deserved approval! — Ricardo Rigaroni, Mar 19 '16 at 18:57

score 1 · Answer 2 · answered Feb 21 '15 at 00:32

Try sending in the Writer as an argument to the method and instead of printing to standard out inside the method, print to the writer:

public void findSpringfield(FileWriter writer)
{
     writer.println("---------------------------------------------------                                               ---------------------");
          writer.println("SPRINGFIELD ZIP CODES");

 for(int i=0; i < data2.length ; i++)
 {
    if(data2[i].getpostalCity().replaceAll("\"","").contains("SPRINGFIELD"))
    {
         writer.println(data2[i].getzipCode().replaceAll("\"",""));               //Prints out zipCodes that have Springfield in them

   }

  }

score 1 · Answer 3 · answered Feb 21 '15 at 00:33

 File file = new File("out.txt");
      BufferedWriter output = new BufferedWriter(new FileWriter(file));
       for(int i=0; i < data2.length ; i++){
          if(data2[i].getpostalCity().replaceAll("\"","").contains("SPRINGFIELD")){
                output.write(data2[i].getzipCode().replaceAll("\"",""));
           }        
         }
      output.close();

this should work but it will require a try-catch block or a throws declaration

score 0 · Answer 4 · answered Feb 21 '15 at 00:36

The way it looks right now every single one of your methods has to implement writing to a file or get file writer as an argument. Both of those will work, but will be very ineficcient.

From what I understood from your question you will be having more of those void methods named findXYZ.

Why not write method void findTown(String townName)? I might be wrong or get wrong impression of what you're trying to achieve but if I'm right then you're going in a wrong direction.

Writing output to text file in a class in java?

4 Answers4