My program keeps crashing after my splash screen. Why?

Question

I am working on an android program. It shows the splash screen but then crashes before it gets to the main activity. These are the errors:

03-01 22:48:10.473    2657-2657/com.example.user.checkbox E/AndroidRuntime? FATAL EXCEPTION: main
    Process: com.example.user.checkbox, PID: 2657
    java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.user.checkbox/com.example.user.favoritebooks.Main}: java.lang.NullPointerException
            at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2334)
            at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2392)
            at android.app.ActivityThread.access$900(ActivityThread.java:169)
            at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1280)
            at android.os.Handler.dispatchMessage(Handler.java:102)
            at android.os.Looper.loop(Looper.java:146)
            at android.app.ActivityThread.main(ActivityThread.java:5487)
            at java.lang.reflect.Method.invokeNative(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:515)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1283)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1099)
            at dalvik.system.NativeStart.main(Native Method)
     Caused by: java.lang.NullPointerException
            at com.example.user.favoritebooks.Main.onCreate(Main.java:36)
            at android.app.Activity.performCreate(Activity.java:5451)
            at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1093)
            at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2298)
            at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2392)
            at android.app.ActivityThread.access$900(ActivityThread.java:169)
            at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1280)
            at android.os.Handler.dispatchMessage(Handler.java:102)
            at android.os.Looper.loop(Looper.java:146)
            at android.app.ActivityThread.main(ActivityThread.java:5487)
            at java.lang.reflect.Method.invokeNative(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:515)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1283)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1099)
            at dalvik.system.NativeStart.main(Native Method)

This is the vicinity of the exception. The last line is where the exception happens. I don't get it, I declared adapter.:

  public static final String favorites = "MyUserChoice" ;
    ArrayList<String> items = new ArrayList<String>();

    @Override
    protected void onCreate(Bundle savedInstanceState)
    {
        getFav = (Button)findViewById(R.id.getchoice);
        savetoshared = getSharedPreferences(favorites, Context.MODE_PRIVATE);
        BookList = (ListView)findViewById(R.id.list);
        clearbutton = (Button)findViewById(R.id.clearall);
        ArrayAdapter<String> adapter = new ArrayAdapter<String>(this, android.R.layout.simple_list_item_multiple_choice, getResources().getStringArray(R.array.Favorite_Books));
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);
        BookList.setAdapter(adapter); //error
        BookList.setChoiceMode(ListView.CHOICE_MODE_MULTIPLE);
        if(savetoshared.contains(favorites))
        {
            LoadSelections();
        }

Check this: http://stackoverflow.com/questions/26079838/android-studio-adb-error-device-unauthorized-please-check-the-confirmat — Shehabic, Mar 02 '15 at 01:47
Debugging is enabled. I've been running programs including this one. — munchschair, Mar 02 '15 at 02:06
check your main activity line 36 there is a nullpointer exception coming, correct it first. — Surender Kumar, Mar 02 '15 at 04:04
You are just doing `setContentView()` .so it is not possible that you have initialised `BookList`..hence the crash. — Droidekas, Mar 02 '15 at 04:22
also as a part of Best Practices,you should really not do anything related to insde the view before calling `setContentView()`..Please post the onCreate of your MainActivity.java — Droidekas, Mar 02 '15 at 04:24

score 0 · Accepted Answer · answered Mar 02 '15 at 04:30

You need to move this code

 getFav = (Button)findViewById(R.id.getchoice);
 savetoshared = getSharedPreferences(favorites, Context.MODE_PRIVATE);
 BookList = (ListView)findViewById(R.id.list);
 clearbutton = (Button)findViewById(R.id.clearall);
 ArrayAdapter<String> adapter = new ArrayAdapter<String>(this, android.R.layout.simple_list_item_multiple_choice, getResources().getStringArray(R.array.Favorite_Books));

after

 super.onCreate(savedInstanceState);
 setContentView(R.layout.main);

because you'r initialize your views before super.onCreate(savedInstanceState); method call.

Basically you can't use `findViewsById` before `setContentView` and can't use `getString`, `getResources`, `setContentView` or pretty much anything before `super.onCreate`. — Eugen Pechanec, Mar 02 '15 at 12:30

My program keeps crashing after my splash screen. Why?

1 Answers1