java preparedStatement.executeUpdate() only insert the last row

Question

This is my code:

String insertQuery = "INSERT INTO Links(PageId, LinkId) values(?, ?)";
PreparedStatement preparedStatement = con.prepareStatement(insertQuery);
Vector<String> links = page.getLinks();    
for (String string : links) {       
    Concept c = dbpedia.findConceptbyTitle(string);                     
    if (c != null) {
        preparedStatement.setInt(1, Integer.parseInt(page.getID()));
        preparedStatement.setInt(2, c.id);
    }    
}
preparedStatement.executeUpdate();

Strangely when I set a breakpoint after executeUpdate, only the last row is inserted in the SQL table!

you need to create preparedStatement every time you want to insert into the loop. — SMA, Mar 02 '15 at 17:20

score 3 · Accepted Answer · answered Mar 02 '15 at 17:50

3

Add preparedStatement.addBatch(); before you leave your loop.

And replace preparedStatement.executeUpdate(); with preparedStatement.executeBatch();.

answered Mar 02 '15 at 17:50

Vanleeuw

46
2

score 1 · Answer 2 · edited May 23 '17 at 12:28

1

You overide your parameters every time only the last executes. Use batch- Statement : http://www.mkyong.com/jdbc/jdbc-preparedstatement-example-batch-update/

Bulk insert in Java using prepared statements batch update

edited May 23 '17 at 12:28

Community

1
1

answered Mar 02 '15 at 17:21

pL4Gu33

2,045
16
38

I added the line preparedStatement.addBatch(); still the same problem. – Andi Keikha Mar 02 '15 at 18:18
1

had you add preparedStatement.executeBatch(); instead of preparedStatement.executeUpdate(); ? – pL4Gu33 Mar 02 '15 at 18:20

java preparedStatement.executeUpdate() only insert the last row

2 Answers2