4

I set up an http server using spray-can, spray-http 1.3.2 and akka 2.3.6. my application.conf doesn't have any akka (or spray) entries. My actor code:

class TestActor extends HttpServiceActor with ActorLogging with PlayJsonSupport {
  val route = get { 
    path("clientapi"/"orders") { 
       complete {{
            log.info("handling request")
            System.err.println("sleeping "+Thread.currentThread().getName)
            Thread.sleep(1000)
            System.err.println("woke up "+Thread.currentThread().getName)
            Seq[Int]()
       }}
    }
  }

  override def receive: Receive = runRoute(route)
}

started like this:

val restService = system.actorOf(Props(classOf[TestActor]), "rest-clientapi")

IO(Http) ! Http.Bind(restService, serviceHost, servicePort)

When I send 10 concurrent requests, they are all accepted immediately by spray and forwarded to different dispatcher actors (according to logging config for akka I have removed from applicaiton.conf lest it influenced the result), but all are handled by the same thread, which sleeps, and only after waking up picks up the next request.

What should I add/change in the configuration? From what I've seen in reference.conf the default executor is a fork-join-executor, so I'd expect all the requests to execute in parallel out of the box.

dk14
  • 22,206
  • 4
  • 51
  • 88
Turin
  • 2,208
  • 15
  • 23
  • from your code I see that there is only one actor (TestActor) to handle all requests, as you've created only one with `system.actorOf`. There is no reason for dispatcher to pick-up some new thread, while the only one thread per time is used by only one actor. – dk14 Mar 05 '15 at 19:08

1 Answers1

9

From your code I see that there is only one TestActor to handle all requests, as you've created only one with system.actorOf. You know, actorOf doesn't create new actor per request - more than that, you have the val there, so it's only one actor. This actor handles requests sequntially one-by-one and your routes are processing inside this actor. There is no reason for dispatcher to pick-up some another thread, while the only one thread per time is used by only one actor, so you've got only one thread in the logs (but it's not guaranteed) - I assume it's first thread in the pool.

Fork-join executor does nothing here except giving first and always same free thread as there is no more actors requiring threads in parallel with current one. So, it receives only one task at time. Even with "work stealing" - it doesn't work til you have some blocked (and marked to have managed block) thread to "steal" resources from. Thread.sleep(1000) itself doesn't mark thread automatically - you should surround it with scala.concurrent.blocking to use "work stealing". Anyway, it still be only one thread while you have only one actor.

If you need to have several actors to process the requests - just pass some akka router actor (it has nothing in common with spray-router):

val restService = context.actorOf(RoundRobinPool(5).props(Props[TestActor]), "router")

That will create a pool (not thread-pool) with 5 actors to serve your requests.

Community
  • 1
  • 1
dk14
  • 22,206
  • 4
  • 51
  • 88
  • 1
    I think I understand where my confusion came from. I was sure that Route is a curried function rq=>rq=>() and my service is responsible only for routing - returning handler function which will get executed by an actor pool managed by spray. Instead I'll have to configure the pool myself and send the ActorRef to the router in the Bind message. Beats me why this isn't mentioned in any examples, I didn't expect using reference config & spray-routing to be tuned for production, but single-threaded model came as a surprise. – Turin Mar 06 '15 at 01:47
  • You and very many others. The examples lead people down a blind alley and don't adequately explain the pitfalls of not spawing new workers in the router (particularly since most HTTP server architectures have already forked before then). – user48956 Nov 10 '15 at 02:29