4

SQL Layer:

I have a table

enter image description here

Entity Framwork Layer:

I have the following rule: all Offers, which have State is null, are Outstanding offers, State is true are Accepted offers, State is false are Declined offers. Also, part of fields used only for Outstanding, part - only for Accepted etc... I use Database first approach, so, I updated EF model from DB and renamed Offer entity to OfferBase and created 3 child classes:

enter image description here

it works fine for add/select entities/records. Right now I want to "move" offer from outstanding to accept offer, so, I need to set Status=true (from Status is null) for appropriate record. But how to do it by Entity Framework? If I try to select outstanding offer as Accept offer I get an null reference (and clearly why)

// record with ID=1 exists, but State is null, so, EF can not find this record and offer will be null after the following string
var offer = (from i in _db.OfferBases.OfType<EFModels.OfferAccepted>() where i.ID == 1 select i).FirstOrDefault();

if I try to select as OfferBase entity I get the following error:

Unable to cast object of type 'System.Data.Entity.DynamicProxies.OfferOutstanding_9DD3E4A5D716F158C6875FA0EDF5D0E52150A406416D4D641148F9AFE2B5A16A' to type 'VTS.EFModels.OfferAccepted'.

    var offerB = (from i in _db.OfferBases where i.ID == 1 select i).FirstOrDefault();
    var offer = (EFModels.OfferAccepted)offerB;

ADDED NOTES ABOUT ARCHITECTURE:

I have 3 types of Offer entity. There are: AcceptOffer, DeclineOffer and OutstandingOffer.

AcceptOffer:

  • UserID
  • ContactID
  • Notes
  • FirstContactDate
  • LastContactDate
  • [... and 5-10 the unique fields...]

DeclineOffer:

  • UserID
  • ContactID
  • Notes
  • [... and 5-10 the unique fields...]

OutstandingOffer:

  • UserID
  • ContactID
  • FirstContactDate
  • LastContactDate
  • [... and 5-10 the unique fields...]

How to do it correctly? Of course, I can select a record, remove from DB and add new with appropriate state value, but how to do it normally?

Oleg Sh
  • 8,496
  • 17
  • 89
  • 159
  • you should read all three articles [here](http://weblogs.asp.net/manavi/inheritance-mapping-strategies-with-entity-framework-code-first-ctp5-part-1-table-per-hierarchy-tph). – tschmit007 Mar 10 '15 at 17:54
  • did not find an answer my question in these articles – Oleg Sh Mar 10 '15 at 18:17
  • 5
    From an OOP point of view. You do not. A class is a thing. Its like saying how do you cast a `Cat` into a `Dog`, when they are both `Animal`s. It makes no sense. So what you are doing is wrong. A class should never represent state. – Aron Mar 13 '15 at 10:15
  • I think the only way that you can change the discriminators in SQL that are used by Entity Framework in TPH (Table Per Hierarchy) scenarios is through a Stored Procedure. That being said, if it's a Polymorphic object that can change, then TPH isn't really as useful as it seems, because it falsely represents that objects in the table could belong to any class in the Hierarchy. – Claies Mar 13 '15 at 10:18
  • @Aron. I understand, that OOP does not allow cast a Cat into a Dog. I just ask how to solve my situation – Oleg Sh Mar 18 '15 at 19:26
  • OlegSh as @Guillaume says. Don't use inheritance. It is only one of many many patterns available to you. Take a look at https://code.google.com/p/stateless/ – Aron Mar 19 '15 at 01:09

2 Answers2

6

You can't change the type of an object once it's created. Your object model seems wrong. Either you delete the outstanding offer and create an accepted offer from it (looks like what you are currently doing) but you may lose relations as you created a new object with a new identity (you can also copy them before removing the old object). Or you want to keep the same object and change its state.

If you want to keep the same identity then preffer composition over inheritance.

Your code could look like this :

public class Offer
{
  public int Id { get; set; }
  public virtual OfferState State { get; set }
}

public class OfferState
{
  public int OfferId { get; set; }
  public string Notes { get; set; }
}

public class AcceptedOfferState : OfferState
{
  public DateTimeOffset AcceptDate { get; set; }
}

public class DeclinedOfferState : OfferState
{
  public DateTimeOffset DeclinedDate { get; set; }
}

If you still want to change the type of the object and keep its identity then you may use stored procedures ; as stated by Noam Ben-Ami (PM owner for EF) : Changing the type of an entity.

Community
  • 1
  • 1
Guillaume
  • 12,824
  • 3
  • 40
  • 48
3

Rather than trying to add these custom classes to your entity framework model, just create them as normal c# classes and then use a projection to convert from the entity framework generated class to your own class e.g.

var accepteOffers= from i in _db.Offers
                   where i.ID == 1 && i.Status == true
                   select new OfferAccepted { AcceptDate = i.AcceptDate, StartTime = i.StartTime /* map all releaveant fields here */};
rdans
  • 2,179
  • 22
  • 32