'Def addition()' not working

Question

import random

def multiply():
    num1 = random.randint(1,12)
    num2 = random.randint(1,12)
    ans = int(input("What is the answer to " + str(num1) + " x " + str(num2) + " ? "))
    correct = (ans == num1 * num2)
    if correct:
        print("You are correct! ")
    else:
        print("Wrong, please try again. ")
    return correct

def addition():
    num1 = random.randint(1,12)
    num2 = random.randint(1,12)
    ans = int(input("What is the answer to " + str(num1) + " + " + str(num2) + " ? "))
    correct = (ans == num1 + num2)
    if correct:
        print("You are correct! ")
    else:
        print("Wrong, please try again. ")
    return correct

name = input("What is your name? ")
maths = input("What mathematics would you like to learn, " + name + "? ")
if maths == "Multiplication" or "m" or "x":
    correct = multiply() 
elif maths == "Addition" or "a" or "x":
    correct == addition()

I am having trouble getting the second 'def addition' to work. The first 'def multiply' works and runs correctly, however the 'def multiply' still won't work.

Any thoughts on how I can make this work?

hi what is ` or "m" or "x":` ? The first `if condition` is always true `if maths == "Multiplication" or "m" or "x":` So your code will call ` multiply()` function every time. — Vivek Sable, Mar 12 '15 at 10:42
Also you can't `or` together strings. Have a list and check whether a value is in it: `if maths in ["Addition", "a", "x"]:` — Peter Wood, Mar 12 '15 at 10:45
You also want to read [How do I test one variable against multiple values?](https://stackoverflow.com/q/15112125); you are making the same mistake in your own boolean tests. — Martijn Pieters, Mar 12 '15 at 10:47

score 2 · Answer 1 · answered Mar 12 '15 at 10:43

2

change == to = as it is assignment

 correct = addition()

answered Mar 12 '15 at 10:43

Danyal Sandeelo

12,196
10
47
78

'Def addition()' not working

1 Answers1