Checkbox item state on menu android

Question

How can I set initial value of checkbox item part of a menu? When I start an Activity I want to set a boolean value saved in Shared Preferences.

<menu xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    tools:context=".LoginActivity">
    <item
        android:id="@+id/checkbox"
        android:title="@string/checkbox"
        android:orderInCategory="10"
        android:showAsAction="never"
        android:visible="true"
        android:checkable="true"
        android:checked="true"/>
</menu>

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    getMenuInflater().inflate(R.menu.login, menu);
    return true;
}

@Override
public boolean onOptionsItemSelected(MenuItem item) {
    if (item.getItemId() == R.id.checkbox){

        if(item.isChecked()){
            item.setChecked(false);
        }else{
            item.setChecked(true);
        }
        SharedPreferences.Editor editor = prefs.edit();
        editor.putBoolean(PrefsConsts.CHECKBOX,item.isChecked());
        editor.commit();

    }
    return true;
}

I can always know what was the value, but I don´t know how to set the new one.

the show what You have done... – Opiatefuchs Mar 18 '15 at 12:47 — Opiatefuchs, Mar 18 '15 at 12:47

score 17 · Accepted Answer · answered Mar 18 '15 at 13:11

First of all, get rid of the checked value in the layout

    <item
        android:id="@+id/action_check"
        android:title="@string/action_check"
        android:orderInCategory="200"
        app:showAsAction="never"
        android:visible="true"
        android:checkable="true"/>

Now you can set it in the code:

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    getMenuInflater().inflate(R.menu.menu_main, menu);
    SharedPreferences settings = getSharedPreferences("settings", 0);
    boolean isChecked = settings.getBoolean("checkbox", false);
    MenuItem item = menu.findItem(R.id.action_check);
    item.setChecked(isChecked);
    return true;
}

@Override
public boolean onOptionsItemSelected(MenuItem item) {
    int id = item.getItemId();
    if (id == R.id.action_check) {
        item.setChecked(!item.isChecked());
        SharedPreferences settings = getSharedPreferences("settings", 0);
        SharedPreferences.Editor editor = settings.edit();
        editor.putBoolean("checkbox", item.isChecked());
        editor.commit();
        return true;
    }
    return super.onOptionsItemSelected(item);
}

Only thing is that commit() should be replaced with apply() for the shared prefs editor. — Meanman, Jan 09 '17 at 21:57
Would love to see how this can be applied to a pop up menu with dynamically added checkboxes. But that is beyond the scope of this question. — TheLettuceMaster, May 18 '17 at 15:47

Checkbox item state on menu android

1 Answers1

Linked