12

I have the following XML file as input:

<Test>
  <callEvents>
    <moc>
      <causeForTermination>0</causeForTermination>
      <serviceCode>
        <teleServiceCode>11</teleServiceCode>
      </serviceCode>
      <dialledDigits>5555555</dialledDigits>
      <connectedNumber>77777</connectedNumber>
    </moc>

    <moc>
      <causeForTermination>0</causeForTermination>
      <serviceCode>
        <teleServiceCode>11</teleServiceCode>
      </serviceCode>
      <dialledDigits>2222222</dialledDigits>
    </moc>
  </callEvents>
  <callEventsCount>100</callEventsCount>
</Test> 

I want to output all the values for dialledDigits. However, my code only displays the first instance of dialledDigits.

dialledDigits {} 5555555

My desired output should contain both instances.

dialledDigits {} 5555555
dialledDigits {} 2222222

Here is my code

import xml.etree.ElementTree as ET
tree = ET.parse('as.xml')
root = tree.getroot()
callevent=root.find('callEvents')

Moc1=callevent.find('moc')

for node in Moc1.getiterator():
    if node.tag=='dialledDigits':
        print node.tag, node.attrib, node.text
Stevoisiak
  • 23,794
  • 27
  • 122
  • 225
Ash
  • 355
  • 1
  • 2
  • 7

3 Answers3

15

You can also write an XPath expression. Just 2 lines instead of 5 and a single loop:

for node in tree.findall('.//callEvents/moc/dialledDigits'):
    print node.tag, node.attrib, node.text 

Demo:

>>> import xml.etree.ElementTree as ET
>>> 
>>> 
>>> tree = ET.parse('as.xml')
>>> root = tree.getroot()
>>> 
>>> for node in tree.findall('.//callEvents/moc/dialledDigits'):
...     print node.tag, node.attrib, node.text
... 
dialledDigits {} 5555555
dialledDigits {} 2222222
alecxe
  • 462,703
  • 120
  • 1,088
  • 1,195
11

Use findall:

moc1 = callevent.findall('moc')

for moc in moc1:
    for node in moc.getiterator():
        if node.tag=='dialledDigits':
            print node.tag, node.attrib, node.text

Output:

dialledDigits {} 5555555
dialledDigits {} 2222222
Leander
  • 508
  • 6
  • 21
Celeo
  • 5,583
  • 8
  • 39
  • 41
  • 1
    But shouldn't there be a way to do it without an explicit if check, but rather like "for node in moc.inter("dialledDigits")"? – LazyCat Feb 28 '18 at 16:45
1

find() will return first tag object, so use finadall() which return all tag objects`

>>> Moc1=callevent.find('moc')
>>> Moc1
<Element 'moc' at 0x869a2ac>
>>> Moc1=callevent.findall('moc')
>>> Moc1
[<Element 'moc' at 0x869a2ac>, <Element 'moc' at 0x869a4ec>]
>>> 

Iterate on it:

>>> Mocs=callevent.findall('moc')
>>> for moc in Mocs:
...     for node in moc.getiterator():
...         if node.tag=='dialledDigits':
...             print node.tag, node.attrib, node.text
... 
dialledDigits {} 5555555
dialledDigits {} 2222222
Vivek Sable
  • 9,938
  • 3
  • 40
  • 56