for loop not suitable?

Question

I have created a for loop. I am trying to loop through lots of members and create a row for each member in a table.

It's looping through too many times. Is it the right type of loop to use?

        <?php
    for ($i = 1; $i = count($u); $i++) 
    {
        ?>
        <tr>
                <?php
                    echo "<td>$i</td>";
                ?>

                <?php
                foreach ($u as $username)
                {
                    echo "<td>$username</td>";
                }
                ?>
                <?php
                foreach ($p as $points)
                {
                    echo "<td>$points</td>";
                }
                ?>
        </tr>
        <?
    }
    ?>

$u and $p are arrays.

Thanks

Sarfraz · Accepted Answer · 2010-05-29T11:43:19.143

4

You can shorten it a bit and remove the inner loops:

<php
 for ($i = 1; $i <= count($u); $i++) 
 {
   echo '<tr>';
   echo "<td>$i</td>";
   echo "<td>$u[$i]</td>";
   echo "<td>$p[$i]</td>";
   echo '</tr>';
 }
 ?>

edited May 29 '10 at 11:43

answered May 29 '10 at 11:29

Sarfraz

377,238
77
533
578

The variables inside the loop would need to be inside tags too. – Turnor May 29 '10 at 11:31
I just did something similar to this, thanks bud. Nice to know im getting the right ideas. – sark9012 May 29 '10 at 11:32

score 2 · Answer 2 · answered May 29 '10 at 11:27

$i = count($u) in the loop is what's causing the problem:

for ($i = 1; $i = count($u); $i++)

On every iteration of the loop, you're assigning count($u) to $i using a single =. Should be

for ($i = 1; $i <= count($u); $i++)

or

for ($i = 0; $i < count($u); $i++)

score 0 · Answer 3 · answered May 29 '10 at 11:37

<?php
$count = count($u);
for ($i = 1; $i < $count; $i++) {
    echo '<tr>';
    echo '<td>' . $i . '</td>';
    foreach ($u as $username) {
        echo '<td>' . $username . '</td>';
    }
    foreach ($p as $points) {
        echo '<td>' . $points . '</td>';
    }
    echo '</tr>';
}
?>

You should count $u before you loop it.

for loop not suitable?

3 Answers3