VBA Strange syntax

Question

See bellow VBE tells it expects an "=" on line 3 inspite of the fact that .Add is a Sub, I don't understant why?

1  Sub Set_Params(key As String, value As Variant)
2      Dim Tranasitions as Collection
3      Transitions.Add (value, key)
4  End Sub

You have a space after `Add`. – miradulo Mar 31 '15 at 16:42 — miradulo, Mar 31 '15 at 16:42
I just tested it without that space, :( same result – sgp667 Mar 31 '15 at 16:43 — sgp667, Mar 31 '15 at 16:43

score 3 · Accepted Answer · edited Mar 31 '15 at 16:54

3

It is because your code doesn't know what Tranasitions is, you have a typo in the declaration (the Dim line).

So to fix it, fix the declaration:

Dim Transitions as Collection

And then remove the () from the call, you don't use them with subs in VBA (unless you put Call in front):

Transitions.Add value, key

edited Mar 31 '15 at 16:54

T.J. Crowder

1,031,962
187
1,923
1,875

answered Mar 31 '15 at 16:44

miradulo

28,857
6
80
93

Bathsheba · Answer 2 · 2015-03-31T17:04:45.193

0

Firstly, refer to the collection using a consistent name.

Then, use Call Transitions.Add etc. or drop the brackets.

Vba has this arcane calling syntax.

edited Mar 31 '15 at 17:04

answered Mar 31 '15 at 16:48

Bathsheba

231,907
34
361
483

Minus one? I'm correct here. Been doing this for years – Bathsheba Mar 31 '15 at 16:50
`Call` is an obsolete keyword from an ancient version of the language. – RubberDuck Mar 31 '15 at 16:54
Actually not. The behaviour is very subtley different. Google it. – Bathsheba Mar 31 '15 at 16:55
I understand the difference @Bathsheba. – RubberDuck Mar 31 '15 at 16:56
People still use `Call` in VBA, and I don't see it's worth a downvote. – Tim Williams Mar 31 '15 at 17:25

score 0 · Answer 3 · answered Mar 31 '15 at 16:49

Remove the parenthesis.

Sub Set_Params(key As String, value As Variant)
    Dim Transitions as New Collection
    Transitions.Add value, key
End Sub

Also, you have to actually create a new instance of Transitions. Oh, and you spelled Transitions as Tranasitions when you declared it. Turn Option Explicit on so that doesn't happen anymore.

VBA Strange syntax

3 Answers3