Powershell not properly reading negative numbers

Question

I have a program and I'm simply trying to check for a negative number but it is not liking it. Have any tips?

$numbers = @(0,1,2,3,4,5,6,7,8,9,-1,-2,-3,-4,-5,-6,-7,-8,-9)
$number = Read-Host "Please input a number: " 
if ($number -le 0)
    {
        Write-Output "Thanks for using the program! Exitting now..."
        $finished = 1
    }
    elseif ($number -notin $numbers)
    {
        Write-Error "Input must be numeric"
        continue
    }
    else
    {
        Write-Host "Good number!"
    }

You are reading into `$number` but checking `$radius`? – Etan Reisner Mar 31 '15 at 18:19 — Etan Reisner, Mar 31 '15 at 18:19
As Etan Reisner said you're not checking $number. – Mar 31 '15 at 18:22 — , Mar 31 '15 at 18:22

score 7 · Accepted Answer · edited Mar 31 '15 at 19:44

7

Read-Host produces [string] output, so you're actually doing a string comparison, and not getting the result you expect. Cast $number to [int] to do a mathematical comparison:

if ([int]$number -le 0)

edited Mar 31 '15 at 19:44

Matt

45,022
8
78
119

answered Mar 31 '15 at 19:10

mjolinor

66,130
7
114
135

Powershell not properly reading negative numbers

1 Answers1

Linked