Trying to convert string into phone number in python?

Question

I'm trying to solve a problem in my python book where you have to convert a string into a phone number. For example: a,b,c = 2 d,e,f = 3 ect. ect.

This is what I've come up with so far but it only ever prints 2, I've been fiddling with it for a while but it still only returns 2. Why?

    def thingie_thing (x) :
      for char in x:
          number = 0
          if char == 'a' or 'b' or 'c':
              number += 2
          elif char == 'd' or 'e' or 'f':
              number += 3
          elif char == 'g' or 'h' or 'i':
              number += 4
          elif char == 'j' or 'k' or 'l':
              number += 5
          elif char == 'm' or 'n' or 'o' or 'p':
              number += 6
          elif char == 'q' or 'r' or 's':
              number += 7
          elif char == 't' or 'u' or 'v':
              number += 8
          elif char == 'w' or 'x' or 'y' or 'z':
              number += 9
    print number

Also, plus equals. You're not appending those numbers you're adding them. Your going to get one number as your output instead of a phone number. — reticentroot, Apr 01 '15 at 03:21
Nevermind, i just saw the question it was linked to. Thanks guys — Ben Cravens, Apr 01 '15 at 03:24
Another different way would be using regular expressions. Try the solution for your phone numbers here: http://repl.it/g66/1 — hexerei software, Apr 01 '15 at 03:39

score 1 · Answer 1 · answered Apr 01 '15 at 03:20

1

If you write if char == 'a' or 'b' or 'c' that means:

if char == 'a'

if 'b':

if 'c':

Since 'b' and 'c' are non-zero characters, they are always true.

You have to see if char=='a' or char=='b' or char=='c'. Only then will you get the truth!

answered Apr 01 '15 at 03:20

ProfOak

541
4
10

score 0 · Answer 2 · answered Apr 01 '15 at 03:20

Since you are using 'a' or 'b' or 'c' the first statement always evaluates to true as it means char == 'a' or 'b' or 'c'.Here 'b' and 'c' are evaluated as true hence it only adds + 2

Use instead char == 'a' or char =='b' or char == 'c'

or

char in ['a','b','c']

Trying to convert string into phone number in python?

2 Answers2