error when adding into vector of pointers

Question

class A{
  Add(const B&);
  vector <B*> vect;
};

A & A::Add(const B& obj){
  vect.push_back(&obj);
  return *this;
}

here I am getting fpermissive error, because argument of push_back is constant, how do I get rid of this?

I tried to create local copy in Add such as

B tmp;
tmp = obj;
vect.push_back(&tmp);

but I am not sure about this, as program step out of this method Add, tmp gets destructed, and adress in vector will point to invalid place in memory?

Are you sure you want to store pointers to objects whose lifetimes you have no idea about? — fredoverflow, Apr 11 '15 at 09:02

score 3 · Accepted Answer · answered Apr 11 '15 at 09:01

3

Your problem arises from API inconsistency. 2 options here:

Drop the const from the signature of Add: Add(B&)
Store const B* pointers in the vector: vector<const B*> vect;

The first option will allow to modify the contents of your objects while the second one will forbid it. The choice depends on your program logic.

answered Apr 11 '15 at 09:01

SomeWittyUsername

18,025
3
42
85

if I use second option, what exactly does vector vect; mean ? will it behave as normal vector? – lllook Apr 11 '15 at 09:04
@lllook It means that the vector will store pointers to immutable objects, i.e., you won't be able to modify these objects. It's important to distinguish between the ability to modify the vector by modifying the pointers stored within to the ability to modify the pointed objects. You'll be able to do the former but not the latter. – SomeWittyUsername Apr 11 '15 at 09:07
thanks, this seems to be an effect I was looking for – lllook Apr 11 '15 at 09:09

score 1 · Answer 2 · answered Apr 11 '15 at 09:14

Your problem is that if you provide a const reference as the function parameter of Add you are telling the compiler that whatever you are passing is never going to be changed as an effect of that function. On the other hand you try to store a non-const pointer in the vector which means that the users of that vector are allowed to change the value correlated to that pointer. To get rid of the error you have to decide what is the type of behaviour you actually want from your program: if you want to store read-only references to your "B" objects then you have to store them as const pointer in the vector. If you want the users of that vector to be able to use non-const functions of B, that is to change B, you have to pass it to the Add function as non-const reference.

error when adding into vector of pointers

2 Answers2