Video is not saving?

Question

So, I'm trying to save a mp4 file from a temp file to the picture directory. The tablet works fine. But it's not working on a samsung nexus. It's not even creating the directory.

 private void moveFileToGallery() {
        File mediaStorageDir = new File(
                Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES),
                VIDEO_DIRECTORY_NAME);
        if (!mediaStorageDir.exists()) {
            if (!mediaStorageDir.mkdirs()) {
                Log.d(VIDEO_DIRECTORY_NAME, ": Failed to create directory");

                return;
            }
        }

        String timeStamp = new SimpleDateFormat("yyyyMMdd_HHmmss")
                .format(new Date());

        String videoFileName = "VID_"+timeStamp+".mp4";
        File source= new File("/sdcard/myvideo.mp4");
        File destination= new File(mediaStorageDir.getPath() + "/"+videoFileName);

        source.renameTo(destination);

        Toast.makeText(getApplicationContext(), "Video Saved to Gallery!", Toast.LENGTH_LONG).show();
    }
}

Anyone know what's wrong with my code?

What error you are getting? and can you access the file source video? — Sohil R. Memon, Apr 20 '15 at 10:25
Yes I can access the source file. The codes went thru, but when I check the file in the directory, it's not there. — tipsywacky, Apr 20 '15 at 10:26

Aditi Parikh · Answer 1 · 2015-06-21T16:54:01.940

3

Print the log of your destination path. I think it is having two slashes.(//).Because you are writing File.seperator+"/". Print the log and check the path.

edited Jun 21 '15 at 16:54

answered Apr 20 '15 at 10:44

Aditi Parikh

1,522
3
13
34

my bad guys actually, i removed "/" in my code already. But it's still not saving the video. – tipsywacky Apr 20 '15 at 10:50
1

Directory is created?? and see if your method source.renameTo(destination); returns true or false..Use debugging.. – Aditi Parikh Apr 20 '15 at 11:04

score 1 · Answer 2 · answered Apr 20 '15 at 10:44

1

Change this line

File destination= new File(mediaStorageDir.getPath() + File.separator+"/"+videoFileName);

to this

File destination= new File(mediaStorageDir.getPath() + File.separator + videoFileName);

you are using an extra "/" which is not required when you are using File.separator. Check if this solve your problem

answered Apr 20 '15 at 10:44

BBdev

4,898
2
31
45

my bad guys actually, i removed "/" in my code already. But it's still not saving the video to my nexus. – tipsywacky Apr 20 '15 at 10:52
Do you get any error or exception when testing on nexus? – BBdev Apr 20 '15 at 10:57
1

Is directory has been created on your phone ?? – BBdev Apr 20 '15 at 11:04
Nope, the directory is not created. – tipsywacky Apr 20 '15 at 11:10
@tipsywacky Put my code instead of your's. It will definitely works! Just try it! I have checked from my side – Sohil R. Memon Apr 20 '15 at 11:11
1

Please visit this question [Creating a directory in /sdcard fails](http://stackoverflow.com/questions/3853472/creating-a-directory-in-sdcard-fails) – BBdev Apr 20 '15 at 11:15
And please check androidmenifest if you have given this permission to your app `android.permission.WRITE_EXTERNAL_STORAGE` – BBdev Apr 20 '15 at 11:18

score 1 · Answer 3 · answered Apr 20 '15 at 11:04

Try this code:

private void moveFileToGallery() {
        File mediaStorageDir = new File(Environment.getExternalStoragePublicDirectory(DIRECTORY_PICTURES),"myvideo");
        if (!mediaStorageDir.exists()) {
            if (!mediaStorageDir.mkdirs()) {
                Log.d("myvideo", ": Failed to create directory");

                return;
            }
        }

        String timeStamp = new SimpleDateFormat("yyyyMMdd_HHmmss").format(new Date());

        String videoFileName = "VID_"+timeStamp+".mp4";
        File source= new File(Environment.getExternalStorageDirectory() + File.separator + "myvideo.mp4");
        File destination= new File(mediaStorageDir.getPath() + File.separator + videoFileName);
        try {
            InputStream inputStream = getContentResolver().openInputStream(Uri.fromFile(source));
            FileOutputStream fileOutputStream = new FileOutputStream(destination);
            copyStream(inputStream, fileOutputStream);
            fileOutputStream.close();
            inputStream.close();

        } catch (IOException e) {
            e.printStackTrace();
        }


        Toast.makeText(getApplicationContext(), "Video Saved to Gallery!", Toast.LENGTH_LONG).show();
    }

Add this function too:

public static void copyStream(InputStream input, OutputStream output)
            throws IOException {

        byte[] buffer = new byte[1024];
        int bytesRead;
        while ((bytesRead = input.read(buffer)) != -1) {
            output.write(buffer, 0, bytesRead);
        }
    }

The thing is my code also works on another android tablet. It just doesn't work on a samsung nexus. — tipsywacky, Apr 20 '15 at 11:18
@tipsywacky Mine is working on both, you should skip your code and go for my code. Hope it works for you too! — Sohil R. Memon, Apr 20 '15 at 11:19

Video is not saving?

3 Answers3