Write to a file doesn't work in java

Question

I am trying to put/save highscore in a file : highscore.txt

But it doesn't work for me. Anybody see why?

Code:

public void miseAJour(IModele modele) {

  if (modele.isFin()) {

    if (modele.aGagner()) {
      Writer writer = null;

      try {
        writer = new BufferedWriter(new OutputStreamWriter(
            new FileOutputStream("/data/highscore.txt"), "utf-8"));
        writer.write(modele.time());
      } catch (IOException ex) {
        // report
      } finally {
        try { writer.close(); } catch (Exception ex) { //ignore }
      }
    }
  }
}

What do you mean by "it doesn't work"? Does it throw an exception? Notice your empty catch blocks, which are probably hiding errors. — Kevin Workman, Apr 22 '15 at 13:44
never leave your catch block empty, log the exceptions, it always assists. As other said, there might be an exception or modele.time() may be null. — Saurabh Jhunjhunwala, Apr 22 '15 at 13:47
Hint: "// ignoring" errors is not a very useful strategy; especially then when "it doesn't work for me". — GhostCat, Apr 22 '15 at 13:48
+1 on the logging of errors - to start with you could just do a System.out.println on ex.getMessage() to see what's wrong. Second, is the path for that file correct - /data/highscore.txt? — Ana Vinatoru, Apr 22 '15 at 13:52
I put a System.out.println and i saw that the error is in exception. @KevinWorkman — Alberto Dimelli, Apr 22 '15 at 13:57
@AnaVinatoru Using `System.out` to log exceptions is a very bad idea. `printstacktrace()` or a logging library are the only right choices. — Pino, Apr 22 '15 at 14:09
I agree that printStackTrace is better - but he's simply ignoring them, even a System.out is better than that. — Ana Vinatoru, Apr 22 '15 at 14:13
Does that file exist? I think FIleOutputStream throws an exception if it doesn't. Check this thread: http://stackoverflow.com/questions/9620683/java-fileoutputstream-create-file-if-not-exists — Ana Vinatoru, Apr 22 '15 at 14:43

moffeltje · Answer 1 · 2015-04-22T14:11:31.910

Firstly, you command a closing bracket
Second, try adding .. before your path name.

Also add an catch or a null check for the writer and/or model.time()

public void miseAJour(IModele modele) {

   if (modele.isFin()) {

     if (modele.aGagner()) {
       Writer writer = null;

       try {
         writer = new BufferedWriter(new OutputStreamWriter(
             new FileOutputStream("../data/highscore.txt"), "utf-8"));
         writer.write(modele.time());
       } catch (Exception ex) {
         System.out.println("Error: " + ex.getMessage());
       } finally {
         try { writer.close(); }
         catch (Exception ex) { 
            System.out.println("Error: " + ex.getMessage());
         }
       }
     }
   }
 }

Write to a file doesn't work in java

1 Answers1