onCreateOptionsMenu not called when starting new activity

Question

My onCreateOptionsMenu works only in my MainActivity and when I try to put another onCreateOptionsMenu in another activity to inflate a different menu it does not display my menu bar (note that I have it setup exactly the same in both activities).

I do not get any errors, it just does not display my menu bar on my secondary activity.

Here is my code:

@Override
protected void onCreate(Bundle savedInstanceState){
    super.onCreate(savedInstanceState);
    setContentView(R.layout.expanded_view_layout);
}

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    getMenuInflater().inflate(R.menu.menu_main, menu);
    return true;
}

@Override
public boolean onOptionsItemSelected(MenuItem item) {
    //noinspection SimplifiableIfStatement
    int id = item.getItemId();
    if (id == R.id.action_back) {
        finish();
    }
    return super.onOptionsItemSelected(item);
}

Also note that I changed getMenuInflater() to super.getMenuInflater() and got same result.

@danny the theme for my entire application is android:theme="@style/Theme.AppCompat.Light" — Errol Green, Apr 24 '15 at 13:20
Have you set any theme for second activity in manifest file? — Piyush, Apr 24 '15 at 13:27
@Piyush Gupta I havent, but I just tried to set the theme to android:theme="@style/Theme.AppCompat.Light" and it still doesnt call onCreateOptionsMenu — Errol Green, Apr 24 '15 at 13:30
@danny that was it danny, why is it that I have to extend ActionBarActivity instead of Activity? — Errol Green, Apr 24 '15 at 13:31
@ErrolGreen Please see this answer: http://stackoverflow.com/questions/26377305/item-with-appshowasaction-not-showing Here you can fin explanation why it has not worked. It is connected with AppCompat library. — Daniel Krzyczkowski, Apr 26 '15 at 15:10

score 9 · Answer 1 · answered May 26 '17 at 12:54

In case you are using tool bar in your activity

@Override
public void onCreate(Bundle savedInstanceState) {
   super.onCreate(savedInstanceState);
   setContentView(R.layout.activity_map);
   mToolbar = (Toolbar) findViewById(R.id.tool_bar);
   setSupportActionBar(mToolbar);
}

srv_sud · Accepted Answer · 2018-10-15T07:21:30.620

6

try adding method of super in your callback onCreateOptionsMenu implementation.

return super.onCreateOptionsMenu(menu);

edited Oct 15 '18 at 07:21

answered Apr 19 '16 at 15:08

srv_sud

647
1
9
26

score 5 · Answer 3 · answered Jan 26 '18 at 11:55

The problem in my case is if extend Activity, then onCreateOptionsMenu is not triggered. Did it manually with in onCreate:

Toolbar toolbar = findViewById(R.id.toolbar);
toolbar.inflateMenu(R.menu.menu_main);

Of course, toolbar is defined in CoordinatorLayout

<android.support.design.widget.AppBarLayout
        android:id="@+id/appBarLayout"
        android:layout_width="match_parent"
        android:layout_height="wrap_content">

        <android.support.v7.widget.Toolbar
            android:id="@+id/toolbar"
            android:layout_width="match_parent"
            android:layout_height="?attr/actionBarSize"
            android:background="?attr/colorPrimary"
            app:layout_scrollFlags="scroll|enterAlways"/>
</android.support.design.widget.AppBarLayout>

after following this example https://learn.microsoft.com/en-us/xamarin/android/user-interface/controls/tool-bar/replacing-the-action-bar#apply-the-custom-theme I found that your soltuion of inflating the menu on create is the only thing that seems to get the menu items to show. Thanks — AntDC, Oct 24 '18 at 10:08

baroni · Answer 4 · 2016-04-19T15:04:39.753

1

don't forget to call parent function like this

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    super.onCreateOptionsMenu(menu);
    ....
}

edited Apr 19 '16 at 15:04

answered Apr 24 '15 at 13:24

baroni

176
8

are you calling return super.onOptionsItemSelected(item); inside onCreateOptionsMenu() or its just an illustration??? – srv_sud Apr 19 '16 at 14:35
this will create a stackoverflow, a infinite loop of calls – Kas Apr 27 '19 at 11:07

score 0 · Answer 5 · answered Apr 24 '15 at 13:44

you should building a new xml menu (Second.xml).

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    // Inflate the menu; this adds items to the action bar if it is present.
    getMenuInflater().inflate(R.menu.second, menu);//Second es your new xml.
    return true;
}

score 0 · Answer 6 · answered May 05 '17 at 11:19

I was having the same problem: - I found the solution that worked for me.

1>Check to what you extend class: - In my case, I have tried my activity with extending AppCompatActivity class and the menu is showing proper and when I changed it to activity class then it stopped displaying.

Not Working: - public class GridViewActivity extends Activity

2>Try to extend your class with AppCompatActivity class instead of activity class.

Working: -

public class GridViewActivity extends AppCompatActivity

score 0 · Answer 7 · edited Aug 29 '17 at 14:09

0

Call setHasOptionsMenu(true) from onCreate.

    @Override
    public void onCreate(@Nullable Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setHasOptionsMenu(true);
     }

edited Aug 29 '17 at 14:09

Jon

9,156
9
56
73

answered Aug 29 '17 at 13:31

Mohammad Zaer

638
7
9

1

can you please elaborate and explain how this improves the already accepted answer ? – Gilles Gouaillardet Aug 29 '17 at 13:52

onCreateOptionsMenu not called when starting new activity

7 Answers7

Related